x11-clocks/wmfishtime

[miwi]

Summary

• Update MASTER_SITES
• Add optional GTK2 support
• Add LICENSE
• Update WWW

[mat]

The summary says "add optional GTK2 support" as it's now the default option, it's badly worded.

x11-clocks/wmfishtime/Makefile

14–17

When defining LICENSE, you should also define LICENSE_FILE if the license is provided in the source distfile.

37–38

Why not keep using MAKE_ARGS to pass all the flags, instead of patching the Makefile ?

41–42

Is there any point to this change ?

[miwi]

• Add LICENSE_FILE
• Restore previous do-install

• Summary: add optional GTK2 support gets replace with: - Add GTK2 support and make it default.

[mat]

What about MAKE_ARGS ?

[miwi]

x11-clocks/wmfishtime/Makefile

37–38

MAKE_ARGS looks for gcc and friends, patching Makefile allow to build with clang and friends.

[mat]

x11-clocks/wmfishtime/Makefile

37–38

I'm sorry, I don't understand that. It's a makefile, it's used by make(1), not the compiler.

if you do:

$ cat Makefile
CFLAGS=foo
all:
      @echo ${CFLAGS}
$ make
foo
$ make CFLAGS=bar
bar

The variables in the Makefile get overwritten by the variables passed as arguments.

[miwi]

• Restore files/patch-Makefile in order to restore MAKE_ARGS as per request.

[miwi]

• Cleanup post-patch from previous patch
• Whitespace fixes

[mat]

x11-clocks/wmfishtime/Makefile

37–38

Whilst I agree, maybe, with the s/1.23/VERSION/ (because nothing says it will or will not be fixed in 1.25) I'm not sure about the gain of running sed twice instead of once on two files.

[miwi]

The reason for patching the version number in both files is because, upstream forgot to bump internal version

fishmon.c
#define VERSION "1.23"

in the manpage links to wrong version:
(from the manpage)

SEE ALSO

http://www.ne.jp/asahi/linux/timecop/

http://www.ne.jp/asahi/linux/timecop/software/wmfishtime-1.23.tar.gz
(original source)

http://freshmeat.net/projects/wmfishtime/

I think thats fine.

[mat]

In D4298#91111, @miwi wrote:

The reason for patching the version number in both files is because, upstream forgot to bump internal version

I get the reason, what I discuss is yet another change that does nothing.

[miwi]

• Update post-patch

[miwi]

• remove that skype thing.. arc is really werid..