Page MenuHomeFreeBSD

math/stp: remove nonsensical sbrk use
ClosedPublic

Authored by brooks on Dec 8 2023, 11:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 24 2024, 4:47 AM
Unknown Object (File)
Jan 6 2024, 11:15 PM
Unknown Object (File)
Dec 11 2023, 6:02 PM
Subscribers

Details

Summary

This code called sbrk(4000000) and beyond error checking ignored
the result meaning the 4MB of address space allocated could
never be used without another call to sbrk and reference to
INITIAL_MEMORY_PREALLOCATION_SIZE, but nothing in the repo does
either.

Submitted upstream as https://github.com/stp/stp/pull/474

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

Compiled but untested on an amd64 world without sbrk.

This is the most bizarre sbrk use I've seen. @imp thought it might have made some sort of sense on an early AT&T UNIX, but even there it's pretty weird.

This revision is now accepted and ready to land.Dec 9 2023, 7:38 AM
This revision was automatically updated to reflect the committed changes.