math/stp: remove nonsensical sbrk use
ClosedPublic
Actions

Authored by brooks on Dec 8 2023, 11:06 PM.

Details

Reviewers

Commits

R11:af6504f9e7ec: math/stp: remove nonsensical sbrk use

Summary

This code called sbrk(4000000) and beyond error checking ignored
the result meaning the 4MB of address space allocated could
never be used without another call to sbrk and reference to
INITIAL_MEMORY_PREALLOCATION_SIZE, but nothing in the repo does
either.

Submitted upstream as https://github.com/stp/stp/pull/474

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Dec 8 2023, 11:06 PM

brooks created this revision.

Harbormaster completed remote builds in B54873: Diff 131194.Dec 8 2023, 11:06 PM

Compiled but untested on an amd64 world without sbrk.

This is the most bizarre sbrk use I've seen. @imp thought it might have made some sort of sense on an early AT&T UNIX, but even there it's pretty weird.

arrowd accepted this revision.Dec 9 2023, 7:38 AM

This revision is now accepted and ready to land.Dec 9 2023, 7:38 AM

Closed by commit R11:af6504f9e7ec: math/stp: remove nonsensical sbrk use (authored by brooks). · Explain WhyDec 11 2023, 5:42 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: R11:af6504f9e7ec: math/stp: remove nonsensical sbrk use.