Page MenuHomeFreeBSD

Fix NFS client handling of copyin() error return
Needs ReviewPublic

Authored by rmacklem on Dec 7 2023, 3:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 3:08 AM
Unknown Object (File)
Sat, Nov 8, 3:03 AM
Unknown Object (File)
Wed, Nov 5, 7:27 AM
Unknown Object (File)
Wed, Nov 5, 7:26 AM
Unknown Object (File)
Wed, Nov 5, 7:20 AM
Unknown Object (File)
Tue, Nov 4, 1:06 AM
Unknown Object (File)
Oct 25 2025, 7:55 AM
Unknown Object (File)
Oct 20 2025, 1:15 PM
Subscribers

Details

Reviewers
markj
emaste
Summary

This patch is based on one by markj@, but includes
a few additions:

  • Added a few m_freem() calls to avoid mbuf leaks
  • Handled nfscl_doiods() return of EFAULT for both read and write.
Test Plan

Not tested by me. Hopefully markj@ will be able to
do so.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/fs/nfsclient/nfs_clcomsubs.c
110โ€“111

Is this intended to remain, or just for development?

sys/fs/nfsclient/nfs_clcomsubs.c
110โ€“111

It's just a diagnostic. A version of this patch was committed as 6fa843f6e647a.