Page MenuHomeFreeBSD
Differential D42948

Fix NFS client handling of copyin() error return
Needs ReviewPublic
Actions

Authored by rmacklem on Dec 7 2023, 3:04 AM.
Tags
None
Referenced Files
F172072690: D42948.diff
Tue, Sep 15, 10:48 PM
Unknown Object (File)
Tue, Sep 15, 1:51 AM
Unknown Object (File)
Sat, Sep 5, 7:55 AM
Unknown Object (File)
Fri, Sep 4, 11:55 PM
Unknown Object (File)
Fri, Sep 4, 6:35 PM
Unknown Object (File)
Fri, Sep 4, 6:12 PM
Unknown Object (File)
Wed, Sep 2, 9:26 PM
Unknown Object (File)
Wed, Sep 2, 3:12 PM
View All 100 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Summary

This patch is based on one by markj@, but includes
a few additions:

  • Added a few m_freem() calls to avoid mbuf leaks
  • Handled nfscl_doiods() return of EFAULT for both read and write.
Test Plan

Not tested by me. Hopefully markj@ will be able to
do so.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rmacklem created this revision.Dec 7 2023, 3:04 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 7 2023, 3:04 AM
rmacklem requested review of this revision.Dec 7 2023, 3:04 AM
emaste added inline comments.Apr 17 2025, 12:43 PM
sys/fs/nfsclient/nfs_clcomsubs.c
110–111

Is this intended to remain, or just for development?

markj added inline comments.Apr 17 2025, 2:31 PM
sys/fs/nfsclient/nfs_clcomsubs.c
110–111

It's just a diagnostic. A version of this patch was committed as 6fa843f6e647a.

Revision Contents
Changeset List

PathSize
sys/
fs/
nfs/
nfs_var.h
nfs_var.h.orig
2 lines
nfsclient/
nfs_clcomsubs.c
nfs_clcomsubs.c.orig
28 lines
nfs_clrpcops.c
nfs_clrpcops.c.orig
23 lines
nfs_clvnops.c
nfs_clvnops.c.orig
4 lines

Diff 131111

View Options

sys/fs/nfs/nfs_var.h

Loading...
View Options

sys/fs/nfsclient/nfs_clcomsubs.c

Loading...
View Options

sys/fs/nfsclient/nfs_clrpcops.c

Loading...
View Options

sys/fs/nfsclient/nfs_clvnops.c

Loading...