Page MenuHomeFreeBSD
Differential D42837

smbus: add compat32 support for SMB ioctls
ClosedPublic
Actions

Authored by stevek on Nov 29 2023, 7:35 PM.
Tags
None
Referenced Files
F132337176: D42837.id130823.diff
Thu, Oct 16, 12:50 AM
F132337173: D42837.id.diff
Thu, Oct 16, 12:50 AM
F132337163: D42837.id130810.diff
Thu, Oct 16, 12:49 AM
Unknown Object (File)
Wed, Oct 15, 2:11 PM
Unknown Object (File)
Sat, Sep 27, 8:37 AM
Unknown Object (File)
Sep 14 2025, 11:48 AM
Unknown Object (File)
Aug 19 2025, 5:11 AM
Unknown Object (File)
Aug 11 2025, 5:57 AM
View All 63 Files
Subscribers
imp

Details

Reviewers
kib
jhb
Commits
rG376330aca184: smbus: add compat32 support for SMB ioctls
Summary

Some of the SMB ioctl request structures contain pointers and need to
handle requests from 32-bit applications on 64-bit kernels.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stevek created this revision.Nov 29 2023, 7:35 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2023, 7:35 PM
stevek requested review of this revision.Nov 29 2023, 7:35 PM
Harbormaster completed remote builds in B54693: Diff 130810.Nov 29 2023, 7:35 PM
stevek added reviewers: kib, jhb.Nov 29 2023, 7:37 PM
jhb accepted this revision.Nov 29 2023, 8:58 PM
This revision is now accepted and ready to land.Nov 29 2023, 8:58 PM
kib added inline comments.Nov 29 2023, 9:07 PM
sys/dev/smbus/smb.c
253

Could any of these calls sleep?

kib accepted this revision.Nov 29 2023, 9:42 PM
kib added inline comments.
sys/dev/smbus/smb.c
253

Ignore the question, it is not worse than the current situation due to small data optimization in kern_ioctl().

Closed by commit rG376330aca184: smbus: add compat32 support for SMB ioctls (authored by stevek). · Explain WhyNov 29 2023, 11:16 PM
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rG376330aca184: smbus: add compat32 support for SMB ioctls.

Revision Contents
Changeset List

PathSize
sys/
dev/
smbus/
142 lines

Diff 130823

View Options

sys/dev/smbus/smb.c

Loading...