sysutils/slurm-wlm: upgrade to 23-11-0-1

[thierry]

Summary

Changelog at https://github.com/SchedMD/slurm/blob/master/NEWS.

Remark: do not commit ATM, because it breaks MPICH.
See https://github.com/pmodels/mpich/issues/6806.

Test Plan

I only use this port as a dependency for net/mpich or net/openmpi.

It would be great if someone who really use it could review this patch.

[diizzy]

Thanks for working on this!

sysutils/slurm-wlm/Makefile

4

Use USE_GITHUB if there's no release archive ( seems to be located here: https://download.schedmd.com/slurm/slurm-23.11.0.tar.bz2 ) ?

45

Please be consistent with DISTVERSION / PORTVERSION (convert everything to DISTVERSION)

96

USE USES= localbase:ldflags

[thierry]

sysutils/slurm-wlm/Makefile

45

They are not the same. DISTVERSION is the released tag, with dash (23-11-0-1), but PORTVERSION transforms the dashes into dots.

[diizzy]

sysutils/slurm-wlm/Makefile

45

Ahh, if that's the intention:

diizzy@freebsd-dev:/usr/ports/net/libwebsockets # make -V DISTVERSION
4-3-3
diizzy@freebsd-dev:/usr/ports/net/libwebsockets # make -V PKGVERSION
4.3.3

[thierry]

sysutils/slurm-wlm/Makefile

45

Yes, it is. But I do not understand: why is PKGVERSION prefetable to PORTVERSION?

[diizzy]

sysutils/slurm-wlm/Makefile

45

PORTVERSION is intended to be used (set) when our framework for DISTVERSION fails to extract a "valid" version that eventually ends up as PKGVERSION and it is a defined variable ( https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n74 ). While it (PORTVERSION) does work ( https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n1358 ) I say its cleaner to user on PKGVERSION looking at how the framework is designed.

[thierry]

sysutils/slurm-wlm/Makefile

45

OK, fine!

[thierry]

My patches have been accepted upstream, and they will release a new version: I will update this differential accordingly.

[thierry]

I have just committed the latest version, fetched directly from SchedMD.