New committer (ports): Michael Osipov (michaelo)
ClosedPublic
Actions

Authored by michaelo on Oct 19 2023, 2:12 PM.

Details

Reviewers

jrm
otis

Commits

R9:4fe7b362318c: New committer (ports): Michael Osipov (michaelo)

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michaelo requested review of this revision.Oct 19 2023, 2:12 PM

michaelo created this revision.

michaelo added a comment.Oct 19 2023, 2:35 PM

This comment was removed by michaelo.

Here is the original patch since I cannot commit to doc:

{F69627630}

Running from 'git arc ...'

Harbormaster completed remote builds in B54086: Diff 129103.Oct 19 2023, 3:34 PM

@jrm , I have now used:

osipovmi@deblndw011x:~/var/Projekte/freebsd/doc (michaelo)
$ git arc update HEAD

but fail to see that the commit message is actually visiable here...

In D42294#965039, @michaelo wrote:
@jrm , I have now used:
osipovmi@deblndw011x:~/var/Projekte/freebsd/doc (michaelo)
$ git arc update HEAD
but fail to see that the commit message is actually visiable here...

I guess it's because you updated the revision and didn't create it with git arc. It is showing diff context now though.

If it's easier, you can paste the full commit log in a comment.

In D42294#965109, @jrm wrote:

If it's easier, you can paste the full commit log in a comment.

I haven't pushed it yet, please have a look at the attached Git-formatted patch. If fine, I will try to push.

In D42294#965110, @michaelo wrote:

In D42294#965109, @jrm wrote:

If it's easier, you can paste the full commit log in a comment.

I haven't pushed it yet, please have a look at the attached Git-formatted patch. If fine, I will try to push.

The diff looks good to me. I would like to take a look at the commit log before approving the push to the FreeBSD repo. You've committed (locally), so should have a commit log to share.

In D42294#965123, @jrm wrote:

In D42294#965110, @michaelo wrote:

In D42294#965109, @jrm wrote:

If it's easier, you can paste the full commit log in a comment.

I haven't pushed it yet, please have a look at the attached Git-formatted patch. If fine, I will try to push.

The diff looks good to me. I would like to take a look at the commit log before approving the push to the FreeBSD repo. You've committed (locally), so should have a commit log to share.

Here you go:

commit c33c408c9fdf7ffc5b9d749dc64b685abfeb7d45 (HEAD -> michaelo)
Author: Michael Osipov <michaelo@FreeBSD.org>
Date:   2023-10-19 16:10:12 +0200

    New committer (ports): Michael Osipov (michaelo)

    Completed steps 1-4 from Committer's Guide.

    Approved by:            jrm (mentor)
    Differential Revision:  https://reviews.freebsd.org/D42294

makeitso