Page MenuHomeFreeBSD

(s)tty: add support for IUTF8 input flag
ClosedPublic

Authored by bnovkov on Oct 3 2023, 4:50 PM.
Tags
None
Referenced Files
F93160425: D42066.id128401.diff
Sat, Sep 7, 6:23 PM
Unknown Object (File)
Sat, Aug 31, 2:27 AM
Unknown Object (File)
Mon, Aug 26, 8:05 AM
Unknown Object (File)
Wed, Aug 21, 12:36 AM
Unknown Object (File)
Mon, Aug 19, 2:50 AM
Unknown Object (File)
Fri, Aug 16, 9:17 PM
Unknown Object (File)
Fri, Aug 16, 7:45 PM
Unknown Object (File)
Sat, Aug 10, 10:47 PM
Subscribers

Details

Summary

This patch adds the necessary kernel and stty code to support setting the IUTF8 flag for ttys.
It is the first of two patches that fix backspace behaviour for UTF-8 encoded characters when in canonical mode.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I like this, modulo namespace pollution issue.

sys/sys/_termios.h
102

what standard defines this symbol? I think we'll need some visibility tweaks.

sys/sys/_termios.h
102

From what I can tell this is a non-standard symbol that was introduced in Linux at some point, but aside from that the actual symbol name is not set in stone. I'm open to suggestions for different names :D

The stty(1) and termios(4) manpages also need to be updated.

sys/sys/_termios.h
102

Then ot needs to be hidden behind BSD_VISIBLE

I've updated the manpages for stty and termios and moved IUTF8 behind __BSD_VISIBLE.

This revision is now accepted and ready to land.Oct 7 2023, 4:37 PM
This revision was automatically updated to reflect the committed changes.