Page MenuHomeFreeBSD
Differential D41952

videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files
ClosedPublic
Actions

Authored by jhb on Sep 23 2023, 10:04 PM.
Tags
None
Referenced Files
F93182886: D41952.id127780.diff
Sat, Sep 7, 10:46 PM
Unknown Object (File)
Fri, Aug 30, 5:44 AM
Unknown Object (File)
Mon, Aug 26, 6:33 PM
Unknown Object (File)
Mon, Aug 26, 6:32 PM
Unknown Object (File)
Mon, Aug 26, 6:32 PM
Unknown Object (File)
Mon, Aug 26, 6:31 PM
Unknown Object (File)
Wed, Aug 21, 5:57 PM
Unknown Object (File)
Wed, Aug 21, 5:57 PM
View All 35 Files
Subscribers
None

Details

Reviewers
imp
emaste
Commits
rGc6dc53e7c80d: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files
rGacbf45f5fc8d: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files
rGbd524e2ddb77: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53687
Build 50578: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 23 2023, 10:04 PM
jhb created this revision.
jhb added a parent revision: D41951: Retire old diskless setup scripts.
Harbormaster completed remote builds in B53687: Diff 127689.Sep 23 2023, 10:04 PM
jhb added a child revision: D41953: videomode: Regenerate files.Sep 23 2023, 10:04 PM
imp accepted this revision.Sep 23 2023, 10:18 PM

Netbsd still uses, for a little while, the id. But in this context it is useless to generate since we don't copy it from the source

This revision is now accepted and ready to land.Sep 23 2023, 10:18 PM
jhb added inline comments.Sep 23 2023, 10:42 PM
sys/dev/videomode/devlist2h.awk
51

This was a bug in the script in that the file in the tree probably had $FreeBSD$ instead.

imp added inline comments.Sep 23 2023, 10:44 PM
sys/dev/videomode/devlist2h.awk
51

Yea. It's a good kill

emaste accepted this revision.Sep 24 2023, 12:41 AM
Closed by commit rGbd524e2ddb77: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files (authored by jhb). · Explain WhySep 25 2023, 2:58 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGbd524e2ddb77: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files.
jhb added a commit: rGacbf45f5fc8d: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files.Oct 24 2023, 6:38 PM
jhb added a commit: rGc6dc53e7c80d: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files.

Revision Contents
Changeset List

PathSize
sys/
dev/
videomode/
2 lines

Diff 127689

View Options

sys/dev/videomode/devlist2h.awk

Loading...