Page MenuHomeFreeBSD

Invent __LFS_VISIBLE for when the _LARGEFILE64_SOURCE is active.
Needs ReviewPublic

Authored by imp on Sep 21 2023, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 12 2024, 9:16 PM
Unknown Object (File)
Nov 23 2024, 10:51 AM
Unknown Object (File)
Nov 13 2024, 9:40 PM
Unknown Object (File)
Nov 10 2024, 3:13 PM
Unknown Object (File)
Nov 9 2024, 11:04 AM
Unknown Object (File)
Nov 9 2024, 6:54 AM
Unknown Object (File)
Oct 29 2024, 3:34 PM
Unknown Object (File)
Oct 1 2024, 1:29 AM
Subscribers
None

Details

Reviewers
kib
cem
Summary

Sponsored by: Netflix

Test Plan

Note: Child review changes off64_t visibility that Conrad added.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53665
Build 50556: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sep 21 2023, 10:16 PM
imp created this revision.
imp added a reviewer: cem.
sys/sys/cdefs.h
729

From what I remember about LARGEFILE, !LARGEFILE does not mean 32 bit, but use of interfaces without 64 suffix. Since for us LARGEFILE does not change anything, we do support both modes.

732

Might be, better name it __OFF64_T_VISIBLE? We do not need to do anything more involved than off64_t.

sys/sys/cdefs.h
729

Yes. I believe so. At most we'd need to flag an illegal combination... I'll have to think about updating this comment.

732

When LARGEFILE is defined, there are more symbols that may need to be visible. Now that we have 64-bit everything, we can just alias them to the normal ones. That's not there yet, but I wanted to allow for it by not making the visible tag name be too narrow.