deskutils/nanonote: Add new port

[jbo]

Summary

Minimalist note taking application.

PR: 273759

[zirias]

deskutils/nanonote/Makefile

14

Upstream provides an "official" distfile, see https://github.com/agateau/nanonote/releases/tag/1.4.0

Please check this, if it's fine, it's preferred over USE_GITHUB.

17

Please also check whether these are contained in the official distfiles (the should). If so, drop the extra github fetching :) (and if not, I would suggest more expressive group names than "x1" and "x2").

[zirias]

deskutils/nanonote/Makefile

12

Upstream README only mentions Qt5, not KDE. Could you check whether this uses is really required?

[zirias]

deskutils/nanonote/Makefile

12

Forget about this one, sorry, too little coffee I guess: I didn't catch the USE_KDE below, probably because I'm used to "USES" blocks without any extra newlines :)

[vidar_karlsen.tech]

deskutils/nanonote/Makefile

9

The license is in fact not the regular 3-clause BSD license, but a "clear" version of it that mentions patents, ref. https://spdx.org/licenses/BSD-3-Clause-Clear.html
I found no other references to this license in the ports tree.

14

Thanks for spotting this, Zirias. The "official" distfile does indeed work, and it contains the submodules, so this can be done without USE_GITHUB.

I tested by removing USE_GITHUB and GH_* and setting
MASTER_SITES= https://github.com/agateau/${PORTNAME}/releases/download/${DISTVERSION}/

[jbo]

Addressing mentioned issues. Patch updated by author.

[zirias]

deskutils/nanonote/Makefile

16

@vidar_karlsen.tech as this now reappeared, did you experience any issue with ninja? If not, it's preferred to allow its usage.

[vidar_karlsen.tech]

deskutils/nanonote/Makefile

16

I wasn't aware it had been removed. The patch that was initially uploaded here in the revision isn't the same as I uploaded to Bugzilla.
It works both with and without :noninja, so let's stick with the preferred way. I'll re-upload to Bugzilla--or should I do it here?

[zirias]

Please just remove the :noninja argument and then

thanks :)

deskutils/nanonote/Makefile

16

@jbo already did build tests with ninja, I just wanted to make sure there's no "esoteric" case which requires avoiding it, thanks for confirming! Then, there's no need for an extra round of reviews for such a tiny change IMHO.