ClosedPublic
Actions

Authored by jhb on Sep 7 2023, 4:28 AM.

Details

Reviewers

Commits

rG83a00a92dab0: Move kern_extattr_* prototypes to <sys/syscallsubr.h>
rG3555be0124a4: Move kern_extattr_* prototypes to <sys/syscallsubr.h>

Summary

All of the kern_* prototypes belong in this header. While here, sort
the prototypes by function name.

Fixes: 6453d4240f6b vfs: Export exattr methods to reuse by Linuxulator
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 7 2023, 4:28 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 7 2023, 4:28 AM

jhb requested review of this revision.Sep 7 2023, 4:28 AM

Harbormaster completed remote builds in B53484: Diff 127021.Sep 7 2023, 4:28 AM

I didn't do this because it doesn't seem anyone but Linuxulator would need these features

This revision is now accepted and ready to land.Sep 8 2023, 2:34 PM

In D41766#952369, @dchagin wrote:

I didn't do this because it doesn't seem anyone but Linuxulator would need these features

In CheriBSD we had kern_extattr_* exported functions already for a COMPAT_FREEBSD64 layer and this didn't conflict as usefully. :) The kern_* we had exported previously though are more like the user_* functions you added though, so the end result is that CheriBSD has both kern_* and user_* of these now exported (kern_* for Linuxulator, user_* for COMPAT_FREEBSD64) with all of the prototypes in <sys/syscallsubr.h>

Closed by commit rG3555be0124a4: Move kern_extattr_* prototypes to <sys/syscallsubr.h> (authored by jhb). · Explain WhySep 8 2023, 11:38 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3555be0124a4: Move kern_extattr_* prototypes to <sys/syscallsubr.h>.

jhb added a commit: rG83a00a92dab0: Move kern_extattr_* prototypes to <sys/syscallsubr.h>.Oct 24 2023, 6:40 PM