Page MenuHomeFreeBSD
Differential D41743

libc: Add test cases for N2680.
ClosedPublic
Actions

Authored by des on Sep 5 2023, 6:56 PM.
Tags
None
Referenced Files
F133502030: D41743.diff
Sun, Oct 26, 6:19 AM
F133441200: D41743.id126978.diff
Sat, Oct 25, 7:59 PM
Unknown Object (File)
Tue, Oct 21, 8:05 AM
Unknown Object (File)
Sat, Oct 18, 9:23 PM
Unknown Object (File)
Sat, Oct 18, 5:36 PM
Unknown Object (File)
Wed, Oct 15, 6:56 AM
Unknown Object (File)
Tue, Oct 14, 7:31 PM
Unknown Object (File)
Sun, Oct 12, 7:11 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
imp
Group Reviewers
tests
Commits
rG12b1c1e3fb44: libc: Add test cases for N2680.
Summary

This adds test cases for %wN and %wfN to the printf(3) and scanf(3) tests.

While here, fix a few nits in the N2630 test cases.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53474
Build 50365: arc lint + arc unit

Event Timeline

des created this revision.Sep 5 2023, 6:56 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 5 2023, 6:56 PM
des requested review of this revision.Sep 5 2023, 6:56 PM
Harbormaster completed remote builds in B53449: Diff 126906.Sep 5 2023, 6:57 PM
des added parent revisions: D41725: libc: Implement N2680., D41726: libc: Add a wide version of snprintf_test., D41727: libc: Suppress format checks on printf() / scanf() tests..Sep 5 2023, 6:57 PM
des added a reviewer: tests.Sep 6 2023, 3:17 PM
imp accepted this revision.Sep 6 2023, 5:40 PM

We had some poorly formed issues with 0x and 0b numbers you added tests for.
Do you want to do the same for poorly formatted formats like %w88d?

This revision is now accepted and ready to land.Sep 6 2023, 5:40 PM
des added a comment.Sep 6 2023, 5:41 PM
In D41743#951667, @imp wrote:

We had some poorly formed issues with 0x and 0b numbers you added tests for.
Do you want to do the same for poorly formatted formats like %w88d?

You're right, I'll get right on it.

des updated this revision to Diff 126978.Sep 6 2023, 6:00 PM

add failure cases

This revision now requires review to proceed.Sep 6 2023, 6:00 PM
Harbormaster completed remote builds in B53474: Diff 126978.Sep 6 2023, 6:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 7 2023, 6:42 AM
Closed by commit rG12b1c1e3fb44: libc: Add test cases for N2680. (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: rG12b1c1e3fb44: libc: Add test cases for N2680..
des mentioned this in rG3c96ab9f1d28: libc: Implement N2680..Sep 7 2023, 8:29 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
stdio/
66 lines
65 lines
66 lines
73 lines

Diff 126978

View Options

lib/libc/tests/stdio/snprintf_test.c

Loading...
View Options

lib/libc/tests/stdio/sscanf_test.c

Loading...
View Options

lib/libc/tests/stdio/swprintf_test.c

Loading...
View Options

lib/libc/tests/stdio/swscanf_test.c

Loading...