Page MenuHomeFreeBSD

riscv: Print stval in dump_regs for fatal exceptions
ClosedPublic

Authored by jhb on Sep 2 2023, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 9:26 PM
Unknown Object (File)
Mon, May 20, 12:58 AM
Unknown Object (File)
Sun, May 19, 9:22 PM
Unknown Object (File)
Sun, May 19, 7:39 PM
Unknown Object (File)
Sun, May 19, 7:38 PM
Unknown Object (File)
Sun, May 19, 7:31 PM
Unknown Object (File)
Sun, May 19, 7:18 PM
Unknown Object (File)
Sun, May 19, 7:17 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 2 2023, 10:17 PM
mhorne added inline comments.
sys/riscv/riscv/trap.c
344

We do print sepc in dump_regs() as well. To me it seems more useful to have both values in this message, or neither.

This revision is now accepted and ready to land.Sep 3 2023, 7:42 PM
sys/riscv/riscv/trap.c
344

Ok. I'm a bit torn actually on whether it's useful to duplicate info. If you only had the panic message without dump_regs for some reason then that might be a reason, or if you are categorizing panics based on the panic message (but the addresses are likely to not have enough of a pattern for that to be useful?)

Also, the load and store access fault's above should also be consistent presumably and print the address if this one does. Perhaps for now it would be best to just add the new line to dump_regs in this diff and leave the other changes alone?

Drop panic message changes

This revision now requires review to proceed.Sep 8 2023, 1:42 AM
This revision is now accepted and ready to land.Sep 8 2023, 6:36 PM