Page MenuHomeFreeBSD

kern_kthread: fork1() does not handle locked Giant
ClosedPublic

Authored by kib on Sep 2 2023, 7:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 17, 9:47 PM
Unknown Object (File)
Tue, May 12, 4:25 PM
Unknown Object (File)
Mon, Apr 27, 12:29 PM
Unknown Object (File)
Apr 24 2026, 4:58 AM
Unknown Object (File)
Apr 22 2026, 7:15 PM
Unknown Object (File)
Apr 18 2026, 6:23 PM
Unknown Object (File)
Apr 17 2026, 5:37 AM
Unknown Object (File)
Apr 17 2026, 1:13 AM
Subscribers

Details

Summary
fork1() does not behave if called under Giant.  For instance, it might
need to call thread_suspend_check() which explicitly verifies that Giant
is not locked.  On the other hand, the kthread KPI is often called from
SYSINIT() which is still Giant-locked.

Handle this by dropping Giant in kthread_add() and kproc_create().

See for instance https://people.freebsd.org/~pho/stress/log/log0485.txt

Style changes will be a separate commit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable