Differential D41542

arm: Add missing no-ctfconvert for fw_stub.awk target
ClosedPublic
Actions

Authored by jrtc27 on Aug 22 2023, 2:57 AM.

Tags

None

Referenced Files

	F86816143: D41542.id.diff
	Wed, Jun 26, 12:36 AM

	Unknown Object (File)
	Thu, Jun 20, 11:42 PM

	Unknown Object (File)
	Thu, Jun 20, 8:53 PM

	Unknown Object (File)
	Thu, Jun 20, 12:56 PM

	Unknown Object (File)
	Thu, Jun 20, 12:15 PM

	Unknown Object (File)
	May 4 2024, 4:34 AM

	Unknown Object (File)
	Mar 13 2024, 1:40 AM

	Unknown Object (File)
	Dec 22 2023, 11:42 PM

View All 14 Files

Subscribers

Details

Reviewers

manu
andrew

Commits

rG87329215f964: arm: Add missing no-ctfconvert for fw_stub.awk target
rGc9b2751d76bd: arm: Add missing no-ctfconvert for fw_stub.awk target

Summary

This target produces a C file not an object file, so using ctfconvert on
it should not be attempted. This keeps it in sync with all other uses of
fw_stub.awk, squashes a warning seen during the build of TEGRA124 on
FreeBSD and avoids the same issue failing the build on non-FreeBSD (such
errors are #ifdef'ed into being warnings on FreeBSD in ctfconvert, which
should be revisited in the future).

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Aug 22 2023, 2:57 AM

Herald added a reviewer: andrew. · View Herald TranscriptAug 22 2023, 2:57 AM

Herald added a subscriber: imp. · View Herald Transcript

jrtc27 requested review of this revision.Aug 22 2023, 2:57 AM

Harbormaster completed remote builds in B53224: Diff 126350.Aug 22 2023, 2:57 AM

manu accepted this revision.Aug 22 2023, 6:54 AM

This revision is now accepted and ready to land.Aug 22 2023, 6:54 AM

Closed by commit rGc9b2751d76bd: arm: Add missing no-ctfconvert for fw_stub.awk target (authored by jrtc27). · Explain WhyAug 22 2023, 8:03 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rGc9b2751d76bd: arm: Add missing no-ctfconvert for fw_stub.awk target.

jrtc27 added a commit: rG87329215f964: arm: Add missing no-ctfconvert for fw_stub.awk target.Sep 4 2023, 8:37 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

nvidia/

tegra124/

2 lines

Diff 126395

sys/arm/nvidia/tegra124/files.tegra124

Loading...