Page MenuHomeFreeBSD
Differential D41458

audio/mumble: with LTO on "QWidget: Cannot create a QWidget without QApplication"
ClosedPublic
Actions

Authored by vvd on Aug 14 2023, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 7:50 AM
Unknown Object (File)
Mon, Jun 17, 8:37 PM
Unknown Object (File)
Mon, Jun 17, 7:09 PM
Unknown Object (File)
May 23 2024, 10:07 PM
Unknown Object (File)
May 23 2024, 10:07 PM
Unknown Object (File)
May 23 2024, 10:02 PM
Unknown Object (File)
May 21 2024, 10:05 AM
Unknown Object (File)
May 7 2024, 10:19 AM
View All 29 Files
Subscribers
makc

Details

Reviewers
arrowd
tcberner
adamw
Commits
R11:43c36a072a0b: audio/mumble: with LTO on "QWidget: Cannot create a QWidget without…
R11:029a21588c8f: audio/mumble: with LTO on "QWidget: Cannot create a QWidget without…
Summary

With option LTO on mumble print "QWidget: Cannot create a QWidget without QApplication" in console and exit.
Mark LTO as broken and turn off by default.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273078
Upstream issue: https://github.com/mumble-voip/mumble/issues/6189

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Aug 14 2023, 10:24 PM
vvd created this revision.
vvd retitled this revision from audio/mumble: with LTO on " to audio/mumble: with LTO on "QWidget: Cannot create a QWidget without QApplication".Aug 14 2023, 10:26 PM
vvd edited the summary of this revision. (Show Details)
vvd added reviewers: arrowd, tcberner, adamw.
vvd edited the summary of this revision. (Show Details)Aug 14 2023, 10:41 PM
arrowd accepted this revision.Aug 15 2023, 6:03 AM
This revision is now accepted and ready to land.Aug 15 2023, 6:03 AM
makc added a subscriber: makc.Aug 15 2023, 8:54 AM
makc added inline comments.
audio/mumble/Makefile
80

Mark the port as LTO_UNSAFE and remove LTO from options. It shouldn't be an option in the first place, same as DEBUG and other build flags.

arrowd added inline comments.Aug 15 2023, 9:28 AM
audio/mumble/Makefile
80

LTO feature knows nothing about the LTO CMake variable.

makc added inline comments.Aug 15 2023, 9:51 AM
audio/mumble/Makefile
80

Is it standard? Shall we add it to cmake.mk?

arrowd added inline comments.Aug 15 2023, 9:53 AM
audio/mumble/Makefile
80

Nope. Which is why it is done like that in this port.

Closed by commit R11:029a21588c8f: audio/mumble: with LTO on "QWidget: Cannot create a QWidget without… (authored by vvd). · Explain WhyAug 15 2023, 12:45 PM
This revision was automatically updated to reflect the committed changes.
vvd added a commit: R11:029a21588c8f: audio/mumble: with LTO on "QWidget: Cannot create a QWidget without….
vvd edited the summary of this revision. (Show Details)Aug 15 2023, 12:46 PM
vvd added a commit: R11:43c36a072a0b: audio/mumble: with LTO on "QWidget: Cannot create a QWidget without….Aug 28 2023, 7:09 PM

Revision Contents
Changeset List

PathSize
audio/
mumble/
6 lines

Diff 126034

View Options

audio/mumble/Makefile

Loading...