Page MenuHomeFreeBSD

nfsstat: Complete libxo transition.
AcceptedPublic

Authored by bses30074_gmail.com on Aug 11 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 8:49 PM
Unknown Object (File)
May 6 2024, 6:02 PM
Unknown Object (File)
May 5 2024, 11:16 AM
Unknown Object (File)
May 2 2024, 2:23 AM
Unknown Object (File)
Apr 30 2024, 3:34 PM
Unknown Object (File)
Dec 13 2023, 4:07 AM
Unknown Object (File)
Dec 12 2023, 1:02 PM
Unknown Object (File)
Dec 6 2023, 2:52 AM

Details

Reviewers
lwhsu
des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53173
Build 50064: arc lint + arc unit

Event Timeline

usr.bin/nfsstat/nfsstat.c
100

Please avoid contiguous blank lines.

des requested changes to this revision.Aug 17 2023, 4:02 PM
des added inline comments.
usr.bin/nfsstat/nfsstat.c
515–516

This should be xo_error().

This revision now requires changes to proceed.Aug 17 2023, 4:02 PM
usr.bin/nfsstat/nfsstat.c
515–516

Maybe use xo_err(1, "usage: nfsstat [-cdemszW] [-w wait]\n"); to replace the fprintf and exit function?

bses30074_gmail.com added inline comments.
usr.bin/nfsstat/nfsstat.c
515–516

Ignore this, xo_err can't replace fprintf.

  • Use xo_error instead of fprintf.
  • Decide using 1 and 0 instead of EXIT_FAILURE and EXIT_SUCESS.
This revision is now accepted and ready to land.Aug 19 2023, 1:34 PM