Page MenuHomeFreeBSD

nfsstat: Complete libxo transition.
ClosedPublic

Authored by yanhaowang on Aug 11 2023, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 7:04 AM
Unknown Object (File)
Thu, Jan 16, 7:00 AM
Unknown Object (File)
Thu, Jan 16, 6:56 AM
Unknown Object (File)
Thu, Jan 16, 6:51 AM
Unknown Object (File)
Thu, Jan 16, 6:49 AM
Unknown Object (File)
Thu, Jan 16, 4:37 AM
Unknown Object (File)
Sun, Jan 12, 1:57 AM
Unknown Object (File)
Nov 24 2024, 1:41 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.bin/nfsstat/nfsstat.c
86

Please avoid contiguous blank lines.

des requested changes to this revision.Aug 17 2023, 4:02 PM
des added inline comments.
usr.bin/nfsstat/nfsstat.c
507–508

This should be xo_error().

This revision now requires changes to proceed.Aug 17 2023, 4:02 PM
usr.bin/nfsstat/nfsstat.c
507–508

Maybe use xo_err(1, "usage: nfsstat [-cdemszW] [-w wait]\n"); to replace the fprintf and exit function?

This comment was removed by yanhaowang.
yanhaowang added inline comments.
usr.bin/nfsstat/nfsstat.c
507–508

Ignore this, xo_err can't replace fprintf.

  • Use xo_error instead of fprintf.
  • Decide using 1 and 0 instead of EXIT_FAILURE and EXIT_SUCESS.
This revision is now accepted and ready to land.Aug 19 2023, 1:34 PM
This revision was automatically updated to reflect the committed changes.