Details
Details
- Reviewers
lwhsu des - Commits
- rGc7bdc25d415a: savecore(8): Complete libxo transition
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 53027 Build 49918: arc lint + arc unit
Event Timeline
| sbin/savecore/savecore.c | ||
|---|---|---|
| 1571 | ||
| sbin/savecore/savecore.c | ||
|---|---|---|
| 1554 | strange, why not logmsg() here? are there other instances? | |
| sbin/savecore/savecore.c | ||
|---|---|---|
| 1554 | I scan the code quickly. It seems if the 'checkfor' flag is true, it uses the printf function instead of logmsg function. The checkfor flag is set if -C is set. The man page of savecore says "display a brief message to indicate the status". So maybe the brief message means using the simple printf function to show the message. | |
| sbin/savecore/savecore.c | ||
|---|---|---|
| 1571 | Ask about this code. Should I always using exit function instead of return in main function. | |
| sbin/savecore/savecore.c | ||
|---|---|---|
| 1571 | It's a matter of taste. The result is the same but calling exit() makes it clearer what's going on. It's especially relevant in programs that have multiple exit points, as is the case here. | |