vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX
ClosedPublic
Actions

Authored by kp on Aug 8 2023, 12:35 PM.

Details

Reviewers

None

Group Reviewers

pfsense
network

Commits

rG580cadd6a5f0: vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX

Summary

If the host doesn't announce VIRTIO_NET_F_CTRL_RX we cannot disable all
multicast traffic. Previously we'd refuse to set the IFF_ALLMULTI flag,
which is the exact opposite of what is actually happening.

This broke things such as igmpproxy.

See also: https://redmine.pfsense.org/issues/14301
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Aug 8 2023, 12:35 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 12:35 PM

kp requested review of this revision.Aug 8 2023, 12:35 PM

Harbormaster completed remote builds in B53011: Diff 125696.Aug 8 2023, 12:35 PM

freebsd_igalic.co added a subscriber: freebsd_igalic.co.Aug 8 2023, 12:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2023, 7:53 AM

Closed by commit rG580cadd6a5f0: vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG580cadd6a5f0: vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RX.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

if_vtnet.c

7 lines

Diff 125862

View Options

sys/dev/virtio/network/if_vtnet.c

vtnet: allow IFF_ALLMULTI to be set without VIRTIO_NET_F_CTRL_RXClosedPublicActions