kdb: Permit a NULL thread credential in kdb_backend_permitted()
ClosedPublic
Actions

Authored by markj on Aug 1 2023, 4:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 3:21 PM

	Unknown Object (File)
	Mon, May 18, 3:16 PM

	Unknown Object (File)
	Mon, May 18, 1:19 PM

	Unknown Object (File)
	Mon, May 18, 1:13 PM

	Unknown Object (File)
	Tue, May 12, 1:41 AM

	Unknown Object (File)
	Sun, May 10, 12:09 PM

	Unknown Object (File)
	Sun, May 10, 12:04 PM

	Unknown Object (File)
	Fri, May 8, 7:08 PM

View All Files

Subscribers

imp

Details

Reviewers

stevek
mhorne

Commits

rGbd16c274c382: kdb: Permit a NULL thread credential in kdb_backend_permitted()

Summary

Early during boot, thread0 runs with td->td_ucred == NULL. This is
fixed up in proc0_init() at SI_SUB_INTRINSIC. If a panic occurs before
then, rather than dereference a NULL pointer, simply allow the thread to
enter KDB.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 1 2023, 4:56 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2023, 4:56 PM

markj requested review of this revision.Aug 1 2023, 4:56 PM

Harbormaster completed remote builds in B52938: Diff 125434.Aug 1 2023, 4:56 PM

stevek accepted this revision.Aug 1 2023, 6:27 PM

This revision is now accepted and ready to land.Aug 1 2023, 6:27 PM

Checks out.

Closed by commit rGbd16c274c382: kdb: Permit a NULL thread credential in kdb_backend_permitted() (authored by markj). · Explain WhyAug 2 2023, 1:16 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbd16c274c382: kdb: Permit a NULL thread credential in kdb_backend_permitted().

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_kdb.c

14 lines

Diff 125479

View Options

kdb: Permit a NULL thread credential in kdb_backend_permitted()ClosedPublicActions