cam: Log more error codes
ClosedPublic
Actions

Authored by imp on Jul 24 2023, 11:44 PM.

Details

Reviewers

ken
mav
chs

Group Reviewers

cam

Commits

rGcf0a543f1f93: cam: Log more error codes

Summary

Log CAM_DEV_NOT_THERE status CCBs because they get dropped if a drive
disappears and these requests timeout or are cancelled. It's useful to
know the outstanding commands for failure analysis. Log
CAM_NVME_STATUS_ERROR status CCBs to bring in NVMe errors (this will be
more important in future commits that expand the information logged).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 24 2023, 11:44 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 24 2023, 11:44 PM

imp requested review of this revision.Jul 24 2023, 11:44 PM

imp added a parent revision: D41167: cam: Log errors from passthru commands.

Harbormaster completed remote builds in B52810: Diff 125106.Jul 24 2023, 11:44 PM

imp added a reviewer: chs.Jul 24 2023, 11:45 PM

NVME sure makes sense, otherwise I am not sure how the list was selected and how sorted.

In D41168#937446, @mav wrote:

NVME sure makes sense, otherwise I am not sure how the list was selected and how sorted.

I'm also unsure how the rest of the list was selected.
I think it was the list of those error codes that Scott thought could be generated by malfunctioning periph devices, based on his experience with a wide range of SIMs...

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 8:55 PM

Closed by commit rGcf0a543f1f93: cam: Log more error codes (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGcf0a543f1f93: cam: Log more error codes.