Page MenuHomeFreeBSD

archivers/rpm4: fix install manual pages, build without PYTHON, silent grab doxygen and dot from graphviz
AbandonedPublic

Authored by vvd on Jul 21 2023, 10:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 2 2024, 10:43 AM
Unknown Object (File)
May 2 2024, 10:38 AM
Unknown Object (File)
May 2 2024, 10:37 AM
Unknown Object (File)
May 2 2024, 9:08 AM
Unknown Object (File)
Dec 22 2023, 10:46 PM
Unknown Object (File)
Oct 14 2023, 5:15 AM
Unknown Object (File)
Oct 14 2023, 5:15 AM
Unknown Object (File)
Aug 23 2023, 9:44 AM
Subscribers
None

Details

Summary
  1. Rebuilding manpages require textproc/hs-pandoc (depends on huge lang/ghc).

Bat package have all manpages prebuilded already. Add option MANPAGES for rebuild manual pages, if off - use prebuilded.

  1. Stage error if PYTHON option is off.
  1. Fix silent grab devel/doxygen and dot from graphics/graphviz.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vvd requested review of this revision.Jul 21 2023, 10:17 AM
vvd created this revision.
archivers/rpm4/Makefile
63–69

%%MANPAGES%% prefix in missing in pkg-plist for manpages files

64

MANPAGES option is not active by default and has to be added here

archivers/rpm4/files/patch-docs_Makefile.am
8

If you remove the PANADOC test, manpages will be installed even if MANPAGES option is disabled

archivers/rpm4/files/patch-docs_Makefile.in
8

same here

vvd marked 4 inline comments as done.Jul 21 2023, 12:27 PM

My english is poor and maybe description isn't clear: option MANPAGES turn on rebuild manual pages. With MANPAGES off - installed included in tarball prebuilded manual pages.

archivers/rpm4/Makefile
63–69

Check description - MANPAGES for REBUILD manual pages, not for install already included in tarball.

64

Manual pages included in tarball installed by default same as was in 4.18.0.

archivers/rpm4/files/patch-docs_Makefile.am
8

PANADOC need for REBUILD manual pages only but not for install included in tarball.

vvd marked 3 inline comments as done.Jul 21 2023, 12:27 PM

Hi Vladimir,

I just committed a fix for rpm4 build with

  • the patches you made for manpages install, removing panadoc dependency
  • including the fixes for python build

but without the MANPAGES option I found unnecessary and quite confusing

I add you as reporter, since you did the heads-up and provide part of the fixes
Thanks for your help

Add please

ac_cv_path_DOXYGEN=no \
ac_cv_prog_HAVE_DOT=no \
ac_cv_path_PANDOC=no

to CONFIGURE_ARGS to prevent silent grab doxygen, graphviz or pandoc if installed.