PCI DEN0115: Reliably check for a memory resource during probe.
ClosedPublic
Actions

Authored by jhb on Jul 13 2023, 8:34 PM.

Tags

None

Referenced Files

	F133108779: D41025.diff
	Thu, Oct 23, 1:27 AM

	Unknown Object (File)
	Wed, Oct 15, 1:17 AM

	Unknown Object (File)
	Mon, Oct 13, 7:18 AM

	Unknown Object (File)
	Mon, Oct 13, 7:18 AM

	Unknown Object (File)
	Mon, Oct 13, 7:18 AM

	Unknown Object (File)
	Sun, Oct 12, 7:07 PM

	Unknown Object (File)
	Sun, Oct 12, 4:26 PM

	Unknown Object (File)
	Fri, Oct 10, 6:33 PM

View All 54 Files

Subscribers

imp

Details

Reviewers

andrew
jrtc27

Commits

rG6582301f83c6: PCI DEN0115: Reliably check for a memory resource during probe.

Summary

rid was stack garbage, so the bus_alloc_resource_any() call could fail
and fall through to the SMCCC version check even if a bridge had a
memory resource.

Debugging help: jrtc27
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 13 2023, 8:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 13 2023, 8:34 PM

jhb requested review of this revision.Jul 13 2023, 8:34 PM

Harbormaster completed remote builds in B52627: Diff 124628.Jul 13 2023, 8:34 PM

jrtc27 accepted this revision.Jul 13 2023, 8:45 PM

This revision is now accepted and ready to land.Jul 13 2023, 8:45 PM

Fixes: c94e4d91da37 ("Add a PCI driver that follows the Arm DEN0115 spec")?

Closed by commit rG6582301f83c6: PCI DEN0115: Reliably check for a memory resource during probe. (authored by jhb). · Explain WhyJul 14 2023, 5:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6582301f83c6: PCI DEN0115: Reliably check for a memory resource during probe..

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic_den0115.c

3 lines

Diff 124685

View Options

sys/dev/pci/pci_host_generic_den0115.c

PCI DEN0115: Reliably check for a memory resource during probe.ClosedPublicActions