Page MenuHomeFreeBSD

support for rockchip rk3308 cru
Needs RevisionPublic

Authored by titus_edc.ro on Jun 22 2023, 10:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 26, 5:01 AM
Unknown Object (File)
Wed, May 20, 2:04 AM
Unknown Object (File)
Apr 30 2026, 9:20 AM
Unknown Object (File)
Apr 27 2026, 8:02 PM
Unknown Object (File)
Apr 26 2026, 10:28 PM
Unknown Object (File)
Apr 21 2026, 5:23 AM
Unknown Object (File)
Apr 16 2026, 9:21 PM
Unknown Object (File)
Apr 15 2026, 11:57 AM
Subscribers

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

file generated mostly with a set of cpp macros to convert from linux macros to freebsd
macros were "validated" against rk3568_cru.c

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested changes to this revision.Jun 22 2023, 1:13 PM
manu added inline comments.
sys/arm64/rockchip/clk/rk3308_cru.c
46

#include <cdt-bindings/clock/rk3308-cru.h> should be enough.

116

Why defining this when we have macros in rc_cru.h ?
Looks like you've copied that rk3568_cru.c which alredy redefines this (and also have bad clock topology, I've raised this already when this was commited).

This revision now requires changes to proceed.Jun 22 2023, 1:13 PM
sys/arm64/rockchip/clk/rk3308_cru.c
116

yes, rk3568_cru.c was the "template", had no idea that was bad
(also was the closest to what linux driver src looked like so it was easiest to adapt)