Page MenuHomeFreeBSD

support for rockchip rk3308 cru
Needs RevisionPublic

Authored by titus_edc.ro on Jun 22 2023, 10:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 2, 2:40 PM
Unknown Object (File)
Sat, Sep 19, 10:46 PM
Unknown Object (File)
Thu, Sep 10, 11:51 AM
Unknown Object (File)
Sep 8 2026, 1:08 PM
Unknown Object (File)
Sep 8 2026, 4:30 AM
Unknown Object (File)
Sep 5 2026, 2:50 PM
Unknown Object (File)
Sep 5 2026, 10:22 AM
Unknown Object (File)
Sep 4 2026, 7:44 PM
Subscribers

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

file generated mostly with a set of cpp macros to convert from linux macros to freebsd
macros were "validated" against rk3568_cru.c

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested changes to this revision.Jun 22 2023, 1:13 PM
manu added inline comments.
sys/arm64/rockchip/clk/rk3308_cru.c
46

#include <cdt-bindings/clock/rk3308-cru.h> should be enough.

116

Why defining this when we have macros in rc_cru.h ?
Looks like you've copied that rk3568_cru.c which alredy redefines this (and also have bad clock topology, I've raised this already when this was commited).

This revision now requires changes to proceed.Jun 22 2023, 1:13 PM
sys/arm64/rockchip/clk/rk3308_cru.c
116

yes, rk3568_cru.c was the "template", had no idea that was bad
(also was the closest to what linux driver src looked like so it was easiest to adapt)