Page MenuHomeFreeBSD

support for rockchip rk3308 cru
Needs RevisionPublic

Authored by titus_edc.ro on Jun 22 2023, 10:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 4:25 PM
Unknown Object (File)
Wed, Sep 24, 6:37 PM
Unknown Object (File)
Aug 14 2025, 11:46 AM
Unknown Object (File)
Aug 13 2025, 10:19 PM
Unknown Object (File)
Aug 12 2025, 7:25 AM
Unknown Object (File)
Aug 12 2025, 1:49 AM
Unknown Object (File)
Aug 8 2025, 11:59 PM
Unknown Object (File)
Aug 8 2025, 8:35 AM
Subscribers

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

file generated mostly with a set of cpp macros to convert from linux macros to freebsd
macros were "validated" against rk3568_cru.c

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu requested changes to this revision.Jun 22 2023, 1:13 PM
manu added inline comments.
sys/arm64/rockchip/clk/rk3308_cru.c
46

#include <cdt-bindings/clock/rk3308-cru.h> should be enough.

116

Why defining this when we have macros in rc_cru.h ?
Looks like you've copied that rk3568_cru.c which alredy redefines this (and also have bad clock topology, I've raised this already when this was commited).

This revision now requires changes to proceed.Jun 22 2023, 1:13 PM
sys/arm64/rockchip/clk/rk3308_cru.c
116

yes, rk3568_cru.c was the "template", had no idea that was bad
(also was the closest to what linux driver src looked like so it was easiest to adapt)