Page MenuHomeFreeBSD

devel/svn2git: Backport svn 1.9 fix
ClosedPublic

Authored by koobs on Nov 2 2015, 7:35 AM.

Details

Summary

Commit log:

devel/svn2git: Backport svn 1.9 fix

- Backport an  pull-request to fix an issue with SVN 1.9 [1]. This is
  running in the FreeBSD cluster (by peter@) to fix a regression after
  upgrading SVN.
  
While I'm here:

- Use OPTIONS helpers for FREEBSD_REPO
- Make patches makepatch compatible (portlint)
- Whitespace align OPTIONS_*

PR:		204023
MFH:		2015Q4
DiffRev:	<url>
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere, 93amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

koobs retitled this revision from to devel/svn2git: Backport svn 1.9 fix.
koobs updated this object.
koobs edited the test plan for this revision. (Show Details)
koobs added a reviewer: dbn.
koobs added a subscriber: peter.

The new patch shows up as an empty file? Otherwise LGTM

Yeh sorry, thats an arc(8) bug cc again again @eadler

Give me a sec and i'll update the diff manually (again again again)

Manually update diff to include new added file contents because phabricator/arc is broken

uqs added a reviewer: uqs.
This revision is now accepted and ready to land.Nov 2 2015, 12:08 PM

Can we get this submitted already?

In D4066#85575, @uqs wrote:

Can we get this submitted already?

I was under the impression @peter had already patched it in the cluster.

Alas, this patch is not enough. svn 1.9 plus a patched svn2git still dies on rev 20 of the base svn repo :(

Has a solution been found? Should I commit this patch regardless?

This revision was automatically updated to reflect the committed changes.