Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 52309 Build 49200: arc lint + arc unit
Event Timeline
Comment Actions
I use the output of getcwd, realpath C functions, and $PWD environment variable to ensure the output of the pwd is correct.
- realpath -> absolute path
- getcwd -> absolute path
- $PWD -> logical path
There are two positive test cases and one negative test case here.
- positive test case 1: pwd in the common path.
- positive test case 2: pwd in the path has soft_link.
- negative test case3: pwd in the path has broken soft_link.
Problems:
- In the pwd source code, it also uses the $PWD and getcwd function. My test case also uses this, will it a little duplicate?
bin/pwd/Makefile | ||
---|---|---|
5–6 ↗ | (On Diff #126014) | Please put this down near .include <bsd.prog.mk>. |
12 ↗ | (On Diff #126014) | This seems superfluous. |
bin/pwd/tests/pwd_test.sh | ||
1 | Copyright? | |
39 | Bad indentation? | |
etc/mtree/BSD.tests.dist | ||
42 ↗ | (On Diff #126014) | This line shouldn't have been touched: please check to make sure the indentation is correct here. |