seq: fix check for rounding error/truncation
ClosedPublic
Actions

Authored by emaste on Jun 19 2023, 1:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 6:28 AM

	Unknown Object (File)
	Oct 11 2024, 7:28 AM

	Unknown Object (File)
	Oct 11 2024, 7:27 AM

	Unknown Object (File)
	Oct 1 2024, 2:14 AM

	Unknown Object (File)
	Sep 26 2024, 6:44 AM

	Unknown Object (File)
	Sep 25 2024, 11:57 PM

	Unknown Object (File)
	Sep 25 2024, 2:26 PM

	Unknown Object (File)
	Sep 22 2024, 11:35 PM

View All 30 Files

Subscribers

imp

Details

Reviewers

yuripv

Commits

rG70af4d57c18f: seq: fix check for rounding error/truncation
rGe54db9a9ccd5: seq: fix check for rounding error/truncation

Summary

Based on OpenBSD 30f0fd29ba6c:

We need to compare the printable version of the last value displayed, not the floating point representation. Otherwise, we may print the last value twice.

PR: 271964

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 19 2023, 1:36 AM

emaste created this revision.

yuripv accepted this revision.Jun 19 2023, 11:10 AM

This revision is now accepted and ready to land.Jun 19 2023, 11:10 AM

Closed by commit rGe54db9a9ccd5: seq: fix check for rounding error/truncation (authored by emaste). · Explain WhyJun 19 2023, 3:29 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGe54db9a9ccd5: seq: fix check for rounding error/truncation.

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2023, 3:29 PM

emaste added a commit: rG70af4d57c18f: seq: fix check for rounding error/truncation.Jun 26 2023, 4:32 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

seq/

seq.c

22 lines

Diff 123398

View Options

seq: fix check for rounding error/truncationClosedPublicActions