pcib: Allocate the memory BAR with the MSI-X table.
ClosedPublic
Actions

Authored by jhb on Jun 16 2023, 8:47 PM.

Details

Reviewers

cperciva
imp

Commits

rGe80d2d894ff1: pcib: Allocate the memory BAR with the MSI-X table.
rG12ce57e6d3e7: pcib: Allocate the memory BAR with the MSI-X table.
rGe6b838363fb4: pcib: Allocate the memory BAR with the MSI-X table.

Summary

This is required for pci_alloc_msix() to work and to thus use
MSI-X interrupts for PCI-e hotplug.

Reported by: cperciva

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 16 2023, 8:47 PM

jhb created this revision.

Harbormaster completed remote builds in B52110: Diff 123355.Jun 16 2023, 8:47 PM

FWIW, this makes it possible for an ena device attached to a PCIe hotplug port to attach, but it's getting watchdog timeouts so there's something else going on which might or might not be related to PCIe/MSIX.

I'm pretty sure that Colin's unique device is the first PCI-e HP bridge that supports MSI-X but not MSI. We have probably just always been falling back to MSI before without anyone noticing.

In D40581#923957, @cperciva wrote:

FWIW, this makes it possible for an ena device attached to a PCIe hotplug port to attach, but it's getting watchdog timeouts so there's something else going on which might or might not be related to PCIe/MSIX.

It sounds like the "something else going on" is a hypervisor bug which is being fixed separately. So as far as FreeBSD is concerned the patch we have here should be the only thing we need.

Is this MFCable? It breaks ABI but it's an ABI in pcib_private.h which maybe we don't care about that?

This revision is now accepted and ready to land.Jun 17 2023, 4:25 AM

It is definitely MFCable, the pcib softc is not a public KBI.

Closed by commit rGe6b838363fb4: pcib: Allocate the memory BAR with the MSI-X table. (authored by jhb). · Explain WhyJun 19 2023, 4:16 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe6b838363fb4: pcib: Allocate the memory BAR with the MSI-X table..

jhb added a commit: rG12ce57e6d3e7: pcib: Allocate the memory BAR with the MSI-X table..Jun 28 2023, 1:33 AM

gordon added a commit: rGe80d2d894ff1: pcib: Allocate the memory BAR with the MSI-X table..Sep 6 2023, 5:37 PM