Page MenuHomeFreeBSD

msun: Correct FreeBSD version in sincos() man page
ClosedPublic

Authored by brad_comstyle.com on May 28 2023, 9:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 9:35 PM
Unknown Object (File)
Sun, Apr 21, 7:49 PM
Unknown Object (File)
Apr 3 2024, 11:54 PM
Unknown Object (File)
Mar 31 2024, 6:37 AM
Unknown Object (File)
Mar 3 2024, 5:14 PM
Unknown Object (File)
Jan 25 2024, 10:57 PM
Unknown Object (File)
Jan 22 2024, 9:16 PM
Unknown Object (File)
Dec 16 2023, 1:14 PM
Subscribers

Details

Summary

The sincos() man page notes the function was added to msun in FreeBSD 9.0 which must have been an oversight in the review as it was commited to 12.0 and then backported to the 11 branch.

So I have provided a diff to correct this to the first FreeBSD version it did ship with which was 11.2.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 9 2023, 7:32 PM

Yeah, I think Steve Kargl actually implemented it in the 9.0 timeframe but only submitted it much later. It's probably good to fixup the history here.

In D40308#921651, @dim wrote:

Yeah, I think Steve Kargl actually implemented it in the 9.0 timeframe but only submitted it much later. It's probably good to fixup the history he

IIRC too, someone, I forget who, put together a bunch of long double support by hackily converting to double, using the double routines, then converting back to get a 'good enough' half-assed answer... I can't recall if that was committed in the 9.x time frame (it may have been) and then removed sometime 11ish when real support came in. I don't think these functions were on the list, though.

This revision was automatically updated to reflect the committed changes.