Page MenuHomeFreeBSD
Differential D40297

Add simple factor/primes regression tests
ClosedPublic
Actions

Authored by ngie on May 27 2023, 4:53 AM.
Tags
None
Referenced Files
F82740062: D40297.diff
Thu, May 2, 5:01 AM
F82732349: D40297.diff
Thu, May 2, 2:30 AM
Unknown Object (File)
Wed, May 1, 12:06 AM
Unknown Object (File)
Tue, Apr 30, 11:36 PM
Unknown Object (File)
Tue, Apr 30, 11:36 PM
Unknown Object (File)
Tue, Apr 30, 8:41 PM
Unknown Object (File)
Mon, Apr 22, 11:35 PM
Unknown Object (File)
Mon, Apr 22, 11:34 PM
View All 37 Files
Subscribers
imp

Details

Reviewers
emaste
Group Reviewers
tests
Commits
rGc60be9ea6b1e: Add simple factor/primes regression tests
Summary

This will help ensure that the change following this
one to support OpenSSL 3 is sane.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie created this revision.May 27 2023, 4:53 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2023, 4:53 AM
ngie requested review of this revision.May 27 2023, 4:53 AM
Harbormaster completed remote builds in B51731: Diff 122507.May 27 2023, 4:53 AM
ngie edited the summary of this revision. (Show Details)May 27 2023, 4:54 AM
ngie added a reviewer: tests.
emaste added inline comments.May 27 2023, 1:27 PM
usr.bin/factor/tests/factor_tests.sh
6

"All rights reserved." has been removed from our standard copyright template. It's unnecessary (but causes no harm if it's there).

36

it seems like factor should reject non-integer args instead

emaste accepted this revision.May 27 2023, 4:21 PM
This revision is now accepted and ready to land.May 27 2023, 4:21 PM
emaste added a comment.May 27 2023, 4:22 PM

anyhow, I think it's reasonable to commit this version and update if/when we change factor to disallow non-integer args

ngie added inline comments.May 27 2023, 6:05 PM
usr.bin/factor/tests/factor_tests.sh
36

Agreed. The fact that factor/primes support non-base 10 values, e.g., a, z, etc, is unexpected/undesirable.

Closed by commit rGc60be9ea6b1e: Add simple factor/primes regression tests (authored by ngie). · Explain WhyMay 27 2023, 6:12 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGc60be9ea6b1e: Add simple factor/primes regression tests.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
factor/
3 lines
tests/
4 lines
85 lines
75 lines

Diff 122520

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/factor/Makefile

Loading...
View Options

usr.bin/factor/tests/Makefile

Loading...
View Options

usr.bin/factor/tests/factor_tests.sh

Loading...
View Options

usr.bin/factor/tests/primes_tests.sh

Loading...