Page MenuHomeFreeBSD

Fixed crypto tool compilation errors.
Needs ReviewPublic

Authored by ksawery.wieczorkowski-rettinger_mobica.com on Mon, May 22, 12:02 PM.
Tags
None
Referenced Files
F62317323: D40201.id122643.diff
Mon, Jun 5, 1:41 AM
F62312997: D40201.id122642.diff
Sun, Jun 4, 11:38 PM
Unknown Object (File)
Sat, Jun 3, 4:48 AM
Unknown Object (File)
Sat, Jun 3, 1:53 AM
Unknown Object (File)
Mon, May 29, 7:55 PM
Unknown Object (File)
Sun, May 28, 12:43 PM
Unknown Object (File)
Sat, May 27, 6:01 AM
Unknown Object (File)
Fri, May 26, 1:52 AM
Subscribers

Details

Reviewers
jhb
markj
Summary

Fixed compilation errors in the cryptocheck, cryptotest, cryptostats, hifnstats, safestats and ipsecstats tools. Added missing cryptostats and cryptotstat declarations in cryptodev.h.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 51791
Build 48682: arc lint + arc unit

Event Timeline

Could you please split the compilation fixes into a separate patch?

tools/tools/crypto/cryptocheck.c
758 ↗(On Diff #122210)

The indentation here was correct before, now it's wrong.

sys/opencrypto/cryptodev.h
326

These fields were removed a while ago. The right solution is to remove references to these fields from userspace utilities, not to re-add them to the kernel.

tools/tools/crypto/cryptotest.c
187

This should probably be size_t instead.

198

Ditto.

262

These can be declared in the for-loop headers where they are used.

648