Page MenuHomeFreeBSD

Fixed crypto tool compilation errors.
Needs ReviewPublic

Authored by ksawery.wieczorkowski-rettinger_mobica.com on May 22 2023, 12:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 15, 12:25 AM
Unknown Object (File)
Tue, Sep 5, 9:33 PM
Unknown Object (File)
Aug 15 2023, 12:36 AM
Unknown Object (File)
Aug 15 2023, 12:27 AM
Unknown Object (File)
Jul 20 2023, 11:27 PM
Unknown Object (File)
Jun 25 2023, 1:51 AM
Unknown Object (File)
Jun 24 2023, 4:59 AM
Unknown Object (File)
Jun 5 2023, 1:41 AM
Subscribers

Details

Reviewers
jhb
markj
Summary

Fixed compilation errors in the cryptocheck, cryptotest, cryptostats, hifnstats, safestats and ipsecstats tools. Added missing cryptostats and cryptotstat declarations in cryptodev.h.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 51791
Build 48682: arc lint + arc unit

Event Timeline

Could you please split the compilation fixes into a separate patch?

tools/tools/crypto/cryptocheck.c
758 ↗(On Diff #122210)

The indentation here was correct before, now it's wrong.

sys/opencrypto/cryptodev.h
326

These fields were removed a while ago. The right solution is to remove references to these fields from userspace utilities, not to re-add them to the kernel.

tools/tools/crypto/cryptotest.c
187

This should probably be size_t instead.

198

Ditto.

262

These can be declared in the for-loop headers where they are used.

648