linux(4): Drop a weird comment from linux_set_syscall_retval on amd64
ClosedPublic
Actions

Authored by dchagin on May 18 2023, 6:55 PM.

Details

Reviewers

Group Reviewers

Commits

rGd56be4992dc7: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64
rGa99b890ecd26: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64

Summary

I agree, it would be great to avoid PCB_FULL_IRET, however we should
follow Linux system call ABI.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.May 18 2023, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2023, 6:55 PM

dchagin requested review of this revision.May 18 2023, 6:55 PM

Harbormaster completed remote builds in B51542: Diff 122088.May 18 2023, 6:55 PM

dchagin added a reviewer: Linux Emulation.May 18 2023, 7:35 PM

dchagin added a project: Linux Emulation.

emaste accepted this revision.May 18 2023, 7:39 PM

emaste added a subscriber: trasz.

This revision is now accepted and ready to land.May 18 2023, 7:39 PM

Closed by commit rGa99b890ecd26: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64 (authored by dchagin). · Explain WhyMay 28 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGa99b890ecd26: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64.

dchagin added a commit: rGd56be4992dc7: linux(4): Drop a weird comment from linux_set_syscall_retval on amd64.Jun 29 2023, 8:26 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

linux_sysvec.c

3 lines

Diff 122536

View Options

sys/amd64/linux/linux_sysvec.c

linux(4): Drop a weird comment from linux_set_syscall_retval on amd64ClosedPublicActions