src.opts.mk: Decouple MK_INCLUDES from MK_TOOLCHAIN
ClosedPublic
Actions

Authored by emaste on May 1 2023, 9:05 PM.

Details

Reviewers

imp
jrtc27

Commits

rG0b4568e36fa6: src.opts.mk: Decouple MK_INCLUDES from MK_TOOLCHAIN

Summary

Prior to 590461a4b89b installation of include files was controlled directly by ${MK_TOOLCHAIN}. 590461a4b89b added an INCLUDES knob which defaulted to YES, and setting WITHOUT_TOOLCHAIN forced it off.

Decouple them now, as there are reasonable use cases for installing libraries and include files without a compiler or other tool chain components.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.May 1 2023, 9:05 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptMay 1 2023, 9:05 PM

emaste requested review of this revision.May 1 2023, 9:05 PM

Maybe worth noting in the commit message that we already install the libraries (static and .so symlinks, not just the .so.X dependencies) for WITHOUT_TOOLCHAIN so it makes sense to install the headers to be able to use them?

This revision is now accepted and ready to land.May 1 2023, 9:12 PM

imp accepted this revision.May 1 2023, 9:15 PM

Closed by commit rG0b4568e36fa6: src.opts.mk: Decouple MK_INCLUDES from MK_TOOLCHAIN (authored by emaste). · Explain WhyMay 2 2023, 12:41 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG0b4568e36fa6: src.opts.mk: Decouple MK_INCLUDES from MK_TOOLCHAIN.