libpmcstat: fix pmcstat -G on recent -CURRENT w/ drm-kmod
ClosedPublic
Actions

Authored by kevans on Apr 29 2023, 3:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 10, 1:08 PM

	Unknown Object (File)
	Mon, May 4, 9:39 AM

	Unknown Object (File)
	Sun, May 3, 1:15 PM

	Unknown Object (File)
	Sun, May 3, 1:00 PM

	Unknown Object (File)
	Sun, May 3, 1:09 AM

	Unknown Object (File)
	Wed, Apr 29, 5:14 PM

	Unknown Object (File)
	Sat, Apr 25, 6:18 AM

	Unknown Object (File)
	Apr 11 2026, 3:11 PM

View All 86 Files

Subscribers

imp

Details

Reviewers

jrtc27
gallatin

Commits

rG77721403c91d: libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod

Summary

The linuxkpi_gplv2.ko module on recent -CURRENT has absolutely no .text
contents, but it's still loaded. Instead of hitting the later assertion
because 0 is not less than 0, we can just skip this image as we should
not have any samples from it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Apr 29 2023, 3:28 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 29 2023, 3:28 AM

kevans requested review of this revision.Apr 29 2023, 3:28 AM

Harbormaster completed remote builds in B51257: Diff 121219.Apr 29 2023, 3:28 AM

gallatin accepted this revision.May 1 2023, 1:55 PM

This revision is now accepted and ready to land.May 1 2023, 1:55 PM

Closed by commit rG77721403c91d: libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod (authored by kevans). · Explain WhyApr 21 2025, 4:00 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG77721403c91d: libpmcstat: fix pmcstat -G on older-ish -CURRENT w/ drm-kmod.

Revision Contents
Changeset List

Path

Size

lib/

libpmcstat/

libpmcstat_image.c

8 lines

Diff 154010

View Options

lib/libpmcstat/libpmcstat_image.c

libpmcstat: fix pmcstat -G on recent -CURRENT w/ drm-kmodClosedPublicActions