Differential D3984

[2/3] queue(3): Enhance queue debugging macros
ClosedPublic
Actions

Authored by cem on Oct 22 2015, 7:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 3:27 AM

	Unknown Object (File)
	Thu, Sep 10, 2:50 PM

	Unknown Object (File)
	Sun, Sep 6, 2:43 AM

	Unknown Object (File)
	Sat, Sep 5, 4:05 PM

	Unknown Object (File)
	Fri, Sep 4, 8:03 PM

	Unknown Object (File)
	Fri, Sep 4, 3:29 AM

	Unknown Object (File)
	Fri, Sep 4, 12:42 AM

	Unknown Object (File)
	Thu, Sep 3, 8:53 PM

Subscribers

Details

Reviewers

emaste
bapt

Commits

rS305627: queue(3): Enhance queue debugging macros

Summary

Split the QUEUE_MACRO_DEBUG into QUEUE_MACRO_DEBUG_TRACE and
QUEUE_MACRO_DEBUG_TRASH.

Add the debug macrso QMD_IS_TRASHED() and QMD_SLIST_CHECK_PREVPTR().

Document these (to some extent) in queue.3.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 9632.Oct 22 2015, 7:52 PM

cem retitled this revision from to [2/3] queue(3): Enhance queue debugging macros.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added a reviewer: emaste.

cem added a reviewer: bapt.Oct 22 2015, 8:16 PM

bdrewery added a subscriber: bdrewery.Oct 22 2015, 8:20 PM

bdrewery added inline comments.

sys/sys/queue.h
112 ↗	(On Diff #9632)	Thanks for keeping a backwards-compat define. I don't like a warning as if some downstream project does use the flag it can't really switch due to portability across older releases or the Linux-supplied queue.h in their bsd packages. The #defines here also remove the need for the UPDATING entry IMO.

cem added inline comments.Oct 22 2015, 8:22 PM

sys/sys/queue.h
112 ↗	(On Diff #9632)	Ok.

emaste accepted this revision.Sep 6 2016, 12:14 AM

emaste edited edge metadata.

This revision is now accepted and ready to land.Sep 6 2016, 12:14 AM

Closed by commit rS305627: queue(3): Enhance queue debugging macros (authored by cem). · Explain WhySep 8 2016, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

6 lines

share/

man/

man3/

1 line

46 lines

sys/

sys/

42 lines

Diff 20213

head/UPDATING

Loading...

head/share/man/man3/Makefile

Loading...

head/share/man/man3/queue.3

Loading...

head/sys/sys/queue.h

Loading...