Page MenuHomeFreeBSD
Differential D39742

bsdinstall avoid subdir depending on parent
ClosedPublic
Actions

Authored by sjg on Apr 21 2023, 3:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 2:11 AM
Unknown Object (File)
Nov 19 2024, 5:28 PM
Unknown Object (File)
Sep 30 2024, 6:26 PM
Unknown Object (File)
Sep 27 2024, 5:40 PM
Unknown Object (File)
Sep 24 2024, 11:43 AM
Unknown Object (File)
Sep 23 2024, 12:08 AM
Unknown Object (File)
Sep 22 2024, 5:16 PM
Unknown Object (File)
Sep 18 2024, 7:44 PM
View All 38 Files
Subscribers
None

Details

Reviewers
stevek
imp
bdrewery
obrien
Commits
rG0c3627f44d49: bsdinstall avoid subdir depending on parent
Summary

When not doing tree walks, it is bad for sub-dirs to depend on
parents. Move the generation of opt_osname.h to distextract
and have others that need that depend on it.

In usr.sbin/bsdinstall use SUBDIR_DEPEND_ so tree walking still works.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sjg requested review of this revision.Apr 21 2023, 3:57 AM
sjg created this revision.
Harbormaster completed remote builds in B51087: Diff 120786.Apr 21 2023, 3:57 AM
obrien added a reviewer: obrien.Apr 21 2023, 4:01 AM
obrien added a subscriber: obrien.
obrien removed a subscriber: obrien.

Looks good.

obrien accepted this revision.Apr 21 2023, 4:03 AM
This revision is now accepted and ready to land.Apr 21 2023, 4:03 AM
Closed by commit rG0c3627f44d49: bsdinstall avoid subdir depending on parent (authored by sjg). · Explain WhyApr 21 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG0c3627f44d49: bsdinstall avoid subdir depending on parent.

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
9 lines
distextract/
11 lines
distfetch/
2 lines
partedit/
2 lines

Diff 120788

View Options

usr.sbin/bsdinstall/Makefile

Loading...
View Options

usr.sbin/bsdinstall/distextract/Makefile

Loading...
View Options

usr.sbin/bsdinstall/distfetch/Makefile

Loading...
View Options

usr.sbin/bsdinstall/partedit/Makefile

Loading...