games/openspades: Convert to USES=magick
ClosedPublic
Actions

Authored by zirias on Apr 16 2023, 2:18 PM.

Details

Reviewers

AMDmi3
tcberner

Commits

R11:132be728cf9c: games/openspades: Convert to USES=magick

Summary

Depends on D39424

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 50944
Build 47835: arc lint + arc unit

zirias requested review of this revision.Apr 16 2023, 2:18 PM

Proposed change materially changes the build dependencies of the port.

games/openspades/Makefile
26	@AMDmi3 Same question as the others. Does OpenSpades require ImageMagick 6 only? Can it build with 7?

This revision now requires changes to proceed.Apr 18 2023, 2:46 AM

I will answer to just one of them:

Any ImageMagick package will conflict with any other, so a version or flavor argument to the USES should *only* be given if strictly needed for the port, otherwise it should go with the user's choice in DEFAULT_VERSIONS
From a direct dependency, you can't know whether this specific version/flavor is really needed
For anything but a lib dependency, it's very unlikely a specific version is needed
For build dependencies, I tested it myself
Reviews are here for the maintainer to double-check, just in case