Page MenuHomeFreeBSD
Differential D39605

graphics/py-img2pdf: Convert to USES=magick
ClosedPublic
Actions

Authored by zirias on Apr 16 2023, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 2:49 AM
Unknown Object (File)
Fri, May 8, 3:08 AM
Unknown Object (File)
Fri, May 8, 2:47 AM
Unknown Object (File)
Fri, May 8, 1:39 AM
Unknown Object (File)
Wed, May 6, 12:28 PM
Unknown Object (File)
Wed, May 6, 2:29 AM
Unknown Object (File)
Thu, Apr 30, 3:14 PM
Unknown Object (File)
Wed, Apr 29, 11:54 AM
View All Files
Subscribers
mat

Details

Reviewers
kai
tcberner
Commits
R11:42ac413c8c8a: graphics/py-img2pdf: Convert to USES=magick
Summary

Depends on D39424

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zirias created this revision.Apr 16 2023, 2:21 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 16 2023, 2:21 PM
zirias requested review of this revision.Apr 16 2023, 2:21 PM
Harbormaster completed remote builds in B50945: Diff 120409.Apr 16 2023, 2:21 PM
kai added inline comments.Apr 16 2023, 4:22 PM
graphics/py-img2pdf/Makefile
24

Would it be possible to change this to magick:6,test? I deliberately set ImageMagick6 for the tests because there were some problems with ImageMagick7.

Otherwise the change LGTM.

zirias marked an inline comment as done.Apr 16 2023, 4:32 PM
zirias added inline comments.
graphics/py-img2pdf/Makefile
24

Of course. Any ImageMagick package will conflict with any other, so not specifying a version and/or flavor will be preferred, but the arguments to the USES are there for a reason ;)

zirias updated this revision to Diff 120416.Apr 16 2023, 4:32 PM
zirias marked an inline comment as done.

Use ImageMagick6.

Harbormaster completed remote builds in B50948: Diff 120416.Apr 16 2023, 4:32 PM
kai accepted this revision.Apr 16 2023, 4:40 PM

LGTM! :)

This revision is now accepted and ready to land.Apr 16 2023, 4:40 PM
Closed by commit R11:42ac413c8c8a: graphics/py-img2pdf: Convert to USES=magick (authored by zirias). · Explain WhyApr 30 2023, 11:11 AM
This revision was automatically updated to reflect the committed changes.
zirias added a commit: R11:42ac413c8c8a: graphics/py-img2pdf: Convert to USES=magick.

Revision Contents
Changeset List

PathSize
graphics/
py-img2pdf/
3 lines

Diff 121261

View Options

graphics/py-img2pdf/Makefile

Loading...