Page MenuHomeFreeBSD
Differential D3957

Mark spidermonkey185 as not for powerpc nor powerpc64.
ClosedPublic
Actions

Authored by jmmv on Oct 21 2015, 2:08 AM.
Tags
None
Referenced Files
F139562389: D3957.id9561.diff
Sat, Dec 13, 1:19 PM
Unknown Object (File)
Sat, Nov 29, 6:48 PM
Unknown Object (File)
Wed, Nov 26, 9:41 PM
Unknown Object (File)
Wed, Nov 26, 1:34 AM
Unknown Object (File)
Sun, Nov 23, 9:51 AM
Unknown Object (File)
Fri, Nov 21, 9:52 AM
Unknown Object (File)
Wed, Nov 19, 9:31 PM
Unknown Object (File)
Wed, Nov 19, 2:12 PM
View All Files
Subscribers
None

Details

Reviewers
koobs
bdrewery
Commits
rP399905: Mark spidermonkey185 as not for PowerPC/PowerPC64
Summary

The code lacks support for any form of PPC and it does not seem trivial
to add such missing pieces. In particular, the MacroAssembler is not
implemented.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 867
Build 867: arc lint + arc unit

Event Timeline

jmmv updated this revision to Diff 9561.Oct 21 2015, 2:08 AM
jmmv retitled this revision from to Mark spidermonkey180 as not for powerpc nor powerpc64..
jmmv updated this object.
jmmv edited the test plan for this revision. (Show Details)
jmmv added reviewers: koobs, bdrewery.
jmmv retitled this revision from Mark spidermonkey180 as not for powerpc nor powerpc64. to Mark spidermonkey185 as not for powerpc nor powerpc64..Oct 21 2015, 2:21 AM
koobs requested changes to this revision.Oct 21 2015, 2:30 AM
koobs edited edge metadata.

Minor edit to the REASON for the purposes of being explicit. other than that it LGTM

Approved with that change made

lang/spidermonkey185/Makefile
15

PowerPC is not supported, use lang/spidermonkey170

This revision now requires changes to proceed.Oct 21 2015, 2:30 AM
bdrewery accepted this revision.Oct 21 2015, 3:04 AM
bdrewery edited edge metadata.
jmmv marked an inline comment as done.Oct 21 2015, 12:01 PM

Suggestion applied. Given that you said "approved with this change made", which I have done, I'm going to submit now.

Thanks!

lang/spidermonkey185/Makefile
15

Done. But if we are going to get nitpicky, that comma is not grammatically correct :-P

Closed by commit rP399905: Mark spidermonkey185 as not for PowerPC/PowerPC64 (authored by jmmv). · Explain WhyOct 21 2015, 12:03 PM
This revision was automatically updated to reflect the committed changes.
jmmv marked an inline comment as done.

Revision Contents
Changeset List

PathSize
lang/
spidermonkey185/
3 lines

Diff 9561

View Options

lang/spidermonkey185/Makefile

Loading...