Page MenuHomeFreeBSD

net-mgmt/ccnet: Update to 5.0.2
AbandonedPublic

Authored by matthew on Oct 20 2015, 12:15 AM.

Details

Summary

Another depend to the Seafile stack that needed to updated.

* Updated to 5.0.2
* Added LICENCE_FILE
* Sorted USES (for portlint)
* Added SHEBANGFIX
* Added Indentation for readability
Test Plan

Currently testing, and using this patch. It works better then current
version. Have created many jails and installed this port to verify working order.
Poudriere is happy on with bulk -t on 102amd64, 102i386, 93amd64, and 93i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 826
Build 826: arc lint + arc unit

Event Timeline

ultima1252_gmail.com retitled this revision from to net-mgmt/ccnet Update with minor fix to make portlint =D.Oct 20 2015, 12:15 AM
ultima1252_gmail.com updated this object.
ultima1252_gmail.com edited the test plan for this revision. (Show Details)
ultima1252_gmail.com updated this revision to Diff 9522.
koobs retitled this revision from net-mgmt/ccnet Update with minor fix to make portlint =D to net-mgmt/ccnet: Update to 4.4.3.Oct 20 2015, 8:36 AM
koobs updated this object.
koobs edited edge metadata.
koobs added a reviewer: koobs.Oct 20 2015, 8:46 AM
koobs requested changes to this revision.
koobs added a subscriber: koobs.
koobs added inline comments.
net-mgmt/ccnet/Makefile
12

LICENSE_FILE?

28
  • Group your USE/USES together
  • Do you intend for this port to depend on the lang/python2 port (the one that provides the python2 symlink, or just say it only supports 2.x? If the latter, use USES=python:-2.7
30

Group USE/USES together

32

I'm not a fan of global scoped *FLAGS (-I${LOCALBASE}/include). If you can de-scope these by using a specific configure or Makefile argument/envvar, then do so.

If it's absolutely, USES=localbase does this for {CPP,C,CXX,LD}FLAGS.

33

I'm not a fan of global scoped *FLAGS (-L${LOCALBASE}/lib). If you can de-scope these by using a specific configure or Makefile argument/envvar, then do so.

If it's absolutely, USES=localbase does this for {CPP,C,CXX,LD}FLAGS.

36

Indentation

39

Group USE/USES together

56

I'd like to see a comment here (at some point) from the maintainer as to why this is necessary, and/or what needs to be done (TODO) to remove it.

This revision now requires changes to proceed.Oct 20 2015, 8:46 AM
ultima1252_gmail.com updated this revision to Diff 9535.
  • Added devel to CATEGORIES
  • Added LICENSE_FILE
ultima1252_gmail.com updated this revision to Diff 9536.
  • Added LICENSE_FILE
  • Changed USES python:-2.7
  • Added localbase to USES
  • Removed CPP/LD FLAGS
  • Indentation for readability on CONFIGURE_ARGS
  • Grouped USE/USES together
  • Added SHEBANGFIX for python
ultima1252_gmail.com marked 7 inline comments as done.Oct 20 2015, 3:20 PM
miwi commandeered this revision.
miwi added a subscriber: miwi.

take

miwi updated this revision to Diff 11779.Dec 30 2015, 5:05 AM
  • Update to 5.0.2
miwi retitled this revision from net-mgmt/ccnet: Update to 4.4.3 to net-mgmt/ccnet: Update to 5.0.2.Dec 30 2015, 5:06 AM
miwi updated this object.
miwi updated this revision to Diff 11780.Dec 30 2015, 5:09 AM
  • Remove regnerated patches

Another seafile related one. The port is at 6.0.0 now.

matthew commandeered this revision.
matthew abandoned this revision.

Overcome by events