Page MenuHomeFreeBSD

makefs: correct iso9660 Rock Ridge TF timestamps
ClosedPublic

Authored by emaste on Mar 22 2023, 11:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 7, 1:41 AM
Unknown Object (File)
Sat, Jan 31, 5:50 PM
Unknown Object (File)
Thu, Jan 29, 6:49 PM
Unknown Object (File)
Tue, Jan 27, 10:38 AM
Unknown Object (File)
Mon, Jan 19, 6:10 AM
Unknown Object (File)
Jan 4 2026, 12:14 AM
Unknown Object (File)
Dec 31 2025, 3:18 AM
Unknown Object (File)
Dec 1 2025, 3:26 AM
Subscribers

Details

Summary
The bit definitions for the TF_* timestamp bits (TF_MODIFY, etc.) were
incorrect, and timestamps were written in the wrong order.

See RRIP 4.1.6 Description of the "TF" System Use Entry for details.

PR:             203531

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.
jrtc27 added a subscriber: jrtc27.

This matches my reading of the spec

This revision is now accepted and ready to land.Mar 23 2023, 12:47 AM
usr.sbin/makefs/cd9660/iso9660_rrip.h
63–65

these don't make sense - the first two are not used, the third is p->attr.rr_entry.NM.flags[0] = (unsigned char) NM_PARENT; (i.e., 0x200 cast to a byte)

to be dealt with later