Page MenuHomeFreeBSD

libpfctl: Don't pass stack garbage to free.
ClosedPublic

Authored by jhb on Mar 22 2023, 2:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 5:40 AM
Unknown Object (File)
Sat, Oct 11, 12:19 PM
Unknown Object (File)
Sat, Oct 11, 12:19 PM
Unknown Object (File)
Sat, Oct 11, 12:18 PM
Unknown Object (File)
Sat, Oct 11, 4:11 AM
Unknown Object (File)
Mon, Oct 6, 4:46 AM
Unknown Object (File)
Sat, Oct 4, 6:03 AM
Unknown Object (File)
Fri, Oct 3, 5:52 PM
Subscribers

Details

Summary

GCC 9 on stable/12 reports a -Wmaybe-uninitialized error for the call
to free in _pfctl_clear_states.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Mar 22 2023, 2:57 AM
mjg added inline comments.
lib/libpfctl/libpfctl.c
1191

but the var is unused to begin with? modulo the bogus free call

mjg added inline comments.
lib/libpfctl/libpfctl.c
1191

huh i somehow did not connect that you removed it altogether, apologies :)

This revision is now accepted and ready to land.Mar 22 2023, 4:57 AM
This revision was automatically updated to reflect the committed changes.