Those adds a new devres and will exectute some function on release.
Sponsored by: Beckhoff Automation GmbH & Co. KG
Details
Details
- Reviewers
bz - Group Reviewers
linuxkpi - Commits
- rGaaf6129c9dcd: linuxkpi: Add devm_add_action and devm_add_action_or_reset
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Feel free to implement the changes before commit they make sense to you.
| sys/compat/linuxkpi/common/include/linux/device.h | ||
|---|---|---|
| 683 | Do we have to #define to something else? Wy can we not use the names as they should be? | |
| sys/compat/linuxkpi/common/src/linux_devres.c | ||
| 246 | Should we check that action is non-NULL to avoid calling a possible NULL pointer on release? | |
| sys/compat/linuxkpi/common/include/linux/device.h | ||
|---|---|---|
| 683 | That's what we did from the beginning for linuxkpi, prefix all the stuff just in case we add a native symbol that is the same in the kernel. | |
| sys/compat/linuxkpi/common/src/linux_devres.c | ||
| 246 | Doesn't seems that Linux does this, it wouldn't hurt to add a check, just wondering what errno we should return then | |
| sys/compat/linuxkpi/common/src/linux_devres.c | ||
|---|---|---|
| 246 | -EINVAL? or add a KASSERT instead? | |
| sys/compat/linuxkpi/common/src/linux_devres.c | ||
|---|---|---|
| 246 | I'll do the KASSERT | |