Page MenuHomeFreeBSD
Differential D39139

ses: update status more promptly after a change
AbandonedPublic
Actions

Authored by asomers on Mar 16 2023, 8:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:35 AM
Unknown Object (File)
Oct 15 2023, 9:33 AM
Unknown Object (File)
Oct 15 2023, 9:33 AM
Unknown Object (File)
Sep 13 2023, 10:57 AM
Unknown Object (File)
Jun 24 2023, 9:52 PM
Unknown Object (File)
May 3 2023, 6:05 PM
Unknown Object (File)
May 2 2023, 7:54 AM
Unknown Object (File)
Mar 30 2023, 2:59 PM
Subscribers
imp

Details

Reviewers
ken
mav
Group Reviewers
cam
Summary

Poll the enclosure promptly after handling any ioctl which can change a
device's status.

Sponsored by: Spectra Logic, Axcient

Test Plan

Manually tested

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50433
Build 47324: arc lint + arc unit

Event Timeline

asomers created this revision.Mar 16 2023, 8:42 PM
Herald added a reviewer: cam. · View Herald TranscriptMar 16 2023, 8:42 PM
Herald added a subscriber: imp. · View Herald Transcript
asomers requested review of this revision.Mar 16 2023, 8:42 PM
Harbormaster completed remote builds in B50433: Diff 118956.Mar 16 2023, 8:42 PM
mav added a comment.Mar 17 2023, 2:09 PM

ses_process_control_request() triggered by ses_set_enc_status() already calls ses_poll_status(), so most of what you are doing should already work. Not sure only about ENCIOC_SETSTRING.

asomers abandoned this revision.Mar 23 2023, 7:39 PM

Yep, I see that you're correct. This is a classic case of two branches solving the same problem in different ways (if you haven't already figured out, I've been trying to reconcile some of Spectra's old ses changes). I'll abandon this revision.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
5 lines

Diff 118956

View Options

sys/cam/scsi/scsi_enc.c

Loading...