Page MenuHomeFreeBSD

Create *.debug hierarchy for /usr/tests
ClosedPublic

Authored by emaste on Oct 14 2015, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 8 2025, 1:14 AM
Unknown Object (File)
Sep 11 2024, 8:25 PM
Unknown Object (File)
Sep 11 2024, 8:25 PM
Unknown Object (File)
Sep 7 2024, 12:59 PM
Unknown Object (File)
Sep 2 2024, 4:31 AM
Unknown Object (File)
Aug 24 2024, 8:49 AM
Unknown Object (File)
Aug 9 2024, 1:24 PM
Unknown Object (File)
Aug 8 2024, 7:45 AM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to Create *.debug hierarchy for /usr/tests.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: bdrewery, ngie.
emaste added a subscriber: tests.
bdrewery edited edge metadata.

Thanks!

For the record, this will let us remove the inconsistent INSTALL -d from bsd.prog.mk/bsd.lib.mk that get ran for every bsd.progs.mk recursion when installing debug symbols. While convenient, install -d is not the normal way to handle directories and only the symbols installation currently are doing this.

This revision is now accepted and ready to land.Oct 14 2015, 7:59 PM

For the record, this will let us remove the inconsistent INSTALL -d

That's intentional - it's so that you can use bsd.prog.mk outside of the src tree and have it create the .debug directory automatically. It's not (supposed to be) used for anything in tree.

ngie requested changes to this revision.Oct 14 2015, 8:28 PM
ngie edited edge metadata.
ngie added inline comments.
etc/Makefile
346

This should be conditionalized on ${MK_DEBUG_FILES} != no.

This revision now requires changes to proceed.Oct 14 2015, 8:28 PM
etc/Makefile
346

No, the debug hierarchy is created unconditionally

etc/Makefile
346

See D1962 for related discussion. This allows e.g. cd /usr/src/bin/ls/tests && make all install clean with WITH_DEBUG_FILES=t

etc/Makefile
346

Ok. I've seen people complain on the lists about empty directories.

I think that creating the debug directory via DEBUGMKDIR would be ok, but I'm not going to quibble over the semantics too much right now.

ngie edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2015, 12:06 AM
This revision was automatically updated to reflect the committed changes.