Paths

Table of Contentst

Differential D38963

eqos: Mechanically convert to IfAPI
ClosedPublic
Actions

Authored by jhibbits on Mar 7 2023, 9:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 6:59 AM

	Unknown Object (File)
	Jan 14 2024, 6:49 AM

	Unknown Object (File)
	Dec 23 2023, 1:11 AM

	Unknown Object (File)
	Dec 17 2023, 4:42 AM

	Unknown Object (File)
	Oct 13 2023, 6:16 PM

	Unknown Object (File)
	Oct 13 2023, 5:15 AM

	Unknown Object (File)
	Jul 13 2023, 6:32 AM

	Unknown Object (File)
	Jul 12 2023, 6:55 AM

View All 15 Files

Subscribers

Details

Reviewers

sos
zlei

Group Reviewers

Commits

rGa472fd7a5737: eqos: Mechanically convert to IfAPI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Mar 7 2023, 9:25 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 7 2023, 9:25 PM

jhibbits requested review of this revision.Mar 7 2023, 9:25 PM

Harbormaster completed remote builds in B50211: Diff 118498.Mar 7 2023, 9:25 PM

Looks good to me.

sys/dev/eqos/if_eqos.c
1216	No local variable `ifp`.

This revision is now accepted and ready to land.Mar 8 2023, 7:00 AM

jhibbits marked an inline comment as done.Mar 8 2023, 2:55 PM

jhibbits added inline comments.

sys/dev/eqos/if_eqos.c
1216	Huh, I wonder how it compiled, then. Very strange.

Closed by commit rGa472fd7a5737: eqos: Mechanically convert to IfAPI (authored by jhibbits). · Explain WhyMar 8 2023, 3:16 PM

This revision was automatically updated to reflect the committed changes.

jhibbits marked an inline comment as done.

jhibbits added a commit: rGa472fd7a5737: eqos: Mechanically convert to IfAPI.

zlei added inline comments.Mar 8 2023, 4:27 PM

sys/dev/eqos/if_eqos.c
1216	Huh, I wonder how it compiled, then. Very strange. `if_eqos` is driver for RK356X SOC Ethernet QoS controller. That is in arm machines. IIUC it will not be built with `amd64/conf/GENERIC` kernel config.

jhibbits added inline comments.Mar 8 2023, 4:52 PM

sys/dev/eqos/if_eqos.c
1216	It also apparently doesn't get built with arm64 LINT and I didn't build GENERIC before submitting the review.

Revision Contents
Changeset List

Path

Size

sys/

dev/

eqos/

44 lines

Diff 118532

sys/dev/eqos/if_eqos.c

Loading...