Page MenuHomeFreeBSD
Differential D38954

*.opts.mk: do not mark OFED as BROKEN_OPTIONS on arm64
AbandonedPublic
Actions

Authored by emaste on Mar 7 2023, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 12:16 PM
Unknown Object (File)
Mar 17 2024, 9:32 PM
Unknown Object (File)
Jan 14 2024, 6:50 AM
Unknown Object (File)
Dec 20 2023, 7:47 AM
Unknown Object (File)
Nov 25 2023, 8:32 PM
Unknown Object (File)
Nov 23 2023, 7:07 AM
Unknown Object (File)
Nov 22 2023, 7:02 PM
Unknown Object (File)
Nov 22 2023, 7:01 PM
View All 24 Files
Subscribers
bdrewery
imp

Details

Reviewers
imp
jhb
Summary

It compiles*, so should not be marked BROKEN.

  • review created in advance of actually testing that it compiles.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Mar 7 2023, 6:45 PM
Herald added a subscriber: bdrewery. · View Herald TranscriptMar 7 2023, 6:45 PM
emaste requested review of this revision.Mar 7 2023, 6:45 PM
emaste added reviewers: imp, jhb.Mar 7 2023, 9:45 PM
emaste added a subscriber: imp.

Yes it builds. @imp can you check my use of MACHINE / __T?

emaste added a comment.Mar 7 2023, 9:46 PM

Also we should make this opt-out for riscv64 and 32-bit arm/powerpc, but that's a change for another time

emaste abandoned this revision.Mar 8 2023, 1:48 AM

Abandon in favour of D38972

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines
sys/
conf/
2 lines

Diff 118482

View Options

share/mk/src.opts.mk

Loading...
View Options

sys/conf/kern.opts.mk

Loading...