Page MenuHomeFreeBSD

ice: Use IfAPI accessor in place of if_capenable reference
AbandonedPublic

Authored by jhibbits on Mar 6 2023, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:07 AM
Unknown Object (File)
Nov 28 2023, 1:35 PM
Unknown Object (File)
Nov 14 2023, 8:38 AM
Unknown Object (File)
Oct 27 2023, 12:32 PM
Unknown Object (File)
Oct 13 2023, 7:36 AM
Unknown Object (File)
Sep 28 2023, 3:51 AM
Unknown Object (File)
Sep 28 2023, 2:32 AM
Unknown Object (File)
Jun 20 2023, 4:20 PM
Subscribers

Details

Reviewers
erj
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

8923de5905 (Update ice to 1.37.7-k) moved to using the ifnet's
capenable instead of one in its own softc in one location. Use the
IfAPI accessor instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50169
Build 47061: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 6 2023, 4:56 PM

@erj was the original change to this intended? Before the change it was:

if ((scctx->isc_capenable & IFCAP_RXCSUM) != 0)

From the rest of the file it looks unintended, but I can't tell.

@erj was the original change to this intended? Before the change it was:

if ((scctx->isc_capenable & IFCAP_RXCSUM) != 0)

From the rest of the file it looks unintended, but I can't tell.

Yeah, I think that change was unintentional.

This comment was removed by erj.

@erj can you fix this the right way given what you also wrote in your now deleted comment? I could just revert the original change to the line if that's all that's needed.

@erj can you fix this the right way given what you also wrote in your now deleted comment? I could just revert the original change to the line if that's all that's needed.

I just reverted the change; we don't need to do something different with it just yet.

In D38929#893449, @erj wrote:

I just reverted the change; we don't need to do something different with it just yet.

Thanks! I'll abandon this now.