xhci(4): Correct PCI device IDs for Zhaoxin USB 3.0 controllers
ClosedPublic
Actions

Authored by zlei on Mar 6 2023, 10:26 AM.

Details

Reviewers

• hselasky
dmitryluhtionov_gmail.com

Commits

rGfd16ee512374: xhci(4): Add IDs for Zhaoxin USB 3.0 controllers
rGf50f53931edb: xhci(4): Correct PCI device IDs for Zhaoxin USB 3.0 controllers

Summary

And minor style fixes.

Fixes: 0d7064d58f89 xhci(4): Add new USB IDs

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mar 6 2023, 10:26 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2023, 10:26 AM

IIUC, the vendor id should follow device id.

I do not have Zhaoxin devices, can you @dmitryluhtionov_gmail.com please verify that this fix works ?

I currently do not have access to the device.
But you patch look is nice.
Can you extend your patch for ehci and uhci controllers ?

In D38921#886192, @dmitryluhtionov_gmail.com wrote:

I currently do not have access to the device.
But you patch look is nice.
Can you extend your patch for ehci and uhci controllers ?

See D38923 and D38924

zlei updated this revision to Diff 118388.Mar 6 2023, 1:29 PM

zlei retitled this revision from xhci(4): Correct PCI device ID for Zhaoxin XHCI USB controllers to xhci(4): Correct PCI device IDs for Zhaoxin USB 3.0 controllers.

zlei edited the summary of this revision. (Show Details)

Good news! The vendor Zhaoxin has verified the fixes.

@hselasky I'd like to commit those patches if there's no objections.